Page MenuHomeFreeBSD
Differential D26359

emulators/virtualbox-ose-kmod: Fix kernel panic on 13-CURRENT with EPOCH and bridge mode.
ClosedPublic
Actions

Authored by nc on Sep 8 2020, 3:31 PM.
Tags
Referenced Files
Unknown Object (File)
Tue, Oct 28, 1:13 PM
Unknown Object (File)
Tue, Oct 28, 1:13 PM
Unknown Object (File)
Tue, Oct 28, 1:12 PM
Unknown Object (File)
Tue, Oct 28, 1:12 PM
Unknown Object (File)
Mon, Oct 27, 11:16 AM
Unknown Object (File)
Sun, Oct 26, 12:51 AM
Unknown Object (File)
Wed, Oct 22, 12:57 AM
Unknown Object (File)
Wed, Oct 22, 12:57 AM
View All Files
Subscribers
0mp
mat
Contributor Reviewers (ports)
vbox

Details

Reviewers
kp
madpilot
jkim
0mp
Commits
rP560502: emulators/virtualbox-ose-kmod: Fix kernel panic on 13-CURRENT with EPOCH and…
Summary

emulators/virtualbox-ose-kmod: Fix kernel panic on 13-CURRENT with EPOCH and bridge mode.

Submitted by: Neel Chauhan <neel AT neelc DOT org>

Test Plan

Use 13-CURRENT, compile virtualbox-ose-kmod with this patch, test bridge mode. It should work.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nc created this revision.Sep 8 2020, 3:31 PM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptSep 8 2020, 3:31 PM
nc requested review of this revision.Sep 8 2020, 3:31 PM
lwhsu added reviewers: kp, madpilot.Sep 8 2020, 4:30 PM
kp accepted this revision.Sep 8 2020, 6:39 PM

It's not just required if you happen to be bridging. ether_demux() expects to be called in epoch context. (Its first call is to NET_EPOCH_ASSERT().)

This revision is now accepted and ready to land.Sep 8 2020, 6:39 PM
lwhsu added a reviewer: jkim.Sep 9 2020, 4:50 PM
jkim accepted this revision.Sep 9 2020, 4:54 PM

LGTM

nc updated this revision to Diff 81732.Jan 6 2021, 4:13 AM

Update PORTREVISION for current Ports tree.

This revision now requires review to proceed.Jan 6 2021, 4:13 AM
Harbormaster completed remote builds in B35965: Diff 81732.Jan 6 2021, 4:13 AM
0mp accepted this revision.Jan 6 2021, 11:39 AM
0mp added a subscriber: 0mp.

You've got my approval to commit, @nc!

This revision is now accepted and ready to land.Jan 6 2021, 11:39 AM
Closed by commit rP560502: emulators/virtualbox-ose-kmod: Fix kernel panic on 13-CURRENT with EPOCH and… (authored by nc). · Explain WhyJan 6 2021, 11:54 AM
This revision was automatically updated to reflect the committed changes.
nc added a commit: rP560502: emulators/virtualbox-ose-kmod: Fix kernel panic on 13-CURRENT with EPOCH and….

Revision Contents
Changeset List

PathSize
head/
emulators/
virtualbox-ose-kmod/
2 lines
virtualbox-ose/
files/
34 lines

Diff 81745

View Options

head/emulators/virtualbox-ose-kmod/Makefile

Loading...
View Options

head/emulators/virtualbox-ose/files/patch-src_VBox_HostDrivers_VBoxNetFlt_freebsd_VBoxNetFlt-freebsd.c

Loading...