Page MenuHomeFreeBSD
Differential D26109

dl_iterate_phdr: provide exclusive locking for callback when statically linked
ClosedPublic
Actions

Authored by kib on Aug 18 2020, 6:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 12, 5:29 AM
Unknown Object (File)
Wed, Feb 11, 8:28 PM
Unknown Object (File)
Wed, Feb 11, 5:43 PM
Unknown Object (File)
Wed, Feb 11, 11:16 AM
Unknown Object (File)
Tue, Feb 10, 12:35 PM
Unknown Object (File)
Sat, Jan 31, 12:25 PM
Unknown Object (File)
Sun, Jan 25, 8:02 PM
Unknown Object (File)
Dec 30 2025, 3:29 AM
View All 87 Files
Subscribers
imp

Details

Reviewers
dim
jhb
emaste
cem
Commits
rS364423: dl_iterate_phdr(3): provide exclusive locking for callback when statically…
Summary

Apparently llvm unwinder depends on the external locking for callback.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Aug 18 2020, 6:16 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 18 2020, 6:16 PM
kib requested review of this revision.Aug 18 2020, 6:16 PM
Harbormaster completed remote builds in B33050: Diff 75959.Aug 18 2020, 6:16 PM
cem accepted this revision.Aug 18 2020, 8:57 PM
This revision is now accepted and ready to land.Aug 18 2020, 8:57 PM
emaste accepted this revision.Aug 18 2020, 9:00 PM

OK with me

kib added a comment.Aug 18 2020, 9:16 PM

So can somebody confirm that this fixes the issue with llvm11 statically linked lld ?

Closed by commit rS364423: dl_iterate_phdr(3): provide exclusive locking for callback when statically… (authored by kib). · Explain WhyAug 20 2020, 3:19 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rS364423: dl_iterate_phdr(3): provide exclusive locking for callback when statically….
emaste added a comment.Aug 20 2020, 3:31 PM

I applied this patch as well as a hack to set _LIBUNWIND_USE_FRAME_HEADER_CACHE and the build was successful
https://cirrus-ci.com/build/6731100590440448

Revision Contents
Changeset List

PathSize
head/
lib/
libc/
gen/
10 lines

Diff 76028

View Options

head/lib/libc/gen/dlfcn.c

Loading...