Paths

Table of Contentst

Differential D26109

dl_iterate_phdr: provide exclusive locking for callback when statically linked
ClosedPublic
Actions

Authored by kib on Aug 18 2020, 6:16 PM.

Tags

None

Referenced Files

	F152010644: D26109.id.diff
	Sun, Apr 12, 2:11 AM

	Unknown Object (File)
	Sat, Apr 11, 12:22 PM

	Unknown Object (File)
	Tue, Apr 7, 7:24 PM

	Unknown Object (File)
	Tue, Apr 7, 2:34 PM

	Unknown Object (File)
	Tue, Apr 7, 12:54 AM

	Unknown Object (File)
	Mon, Apr 6, 2:08 AM

	Unknown Object (File)
	Sun, Apr 5, 4:38 PM

	Unknown Object (File)
	Sat, Apr 4, 9:58 PM

Subscribers

Details

Reviewers

dim
jhb
emaste
cem

Commits

rS364423: dl_iterate_phdr(3): provide exclusive locking for callback when statically…

Summary

Apparently llvm unwinder depends on the external locking for callback.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Aug 18 2020, 6:16 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 18 2020, 6:16 PM

kib requested review of this revision.Aug 18 2020, 6:16 PM

Harbormaster completed remote builds in B33050: Diff 75959.Aug 18 2020, 6:16 PM

cem accepted this revision.Aug 18 2020, 8:57 PM

This revision is now accepted and ready to land.Aug 18 2020, 8:57 PM

OK with me

So can somebody confirm that this fixes the issue with llvm11 statically linked lld ?

Closed by commit rS364423: dl_iterate_phdr(3): provide exclusive locking for callback when statically… (authored by kib). · Explain WhyAug 20 2020, 3:19 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS364423: dl_iterate_phdr(3): provide exclusive locking for callback when statically….

I applied this patch as well as a hack to set _LIBUNWIND_USE_FRAME_HEADER_CACHE and the build was successful
https://cirrus-ci.com/build/6731100590440448

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

gen/

10 lines

Diff 76028

head/lib/libc/gen/dlfcn.c

Loading...