lib${libcompat} from CFLAGS to LDFLAGS.
ClosedPublic
Actions

Authored by jhb on Aug 14 2020, 5:29 PM.

Details

Reviewers

brooks
emaste
bdrewery

Commits

rS364318: Move -L${LIBCOMPATTMP}/usr/lib${libcompat} from CFLAGS to LDFLAGS.

Summary

This is only needed when linking and fixes various "unused command
line argument" warnings during the lib32 build.

While here, trim a redundant -L from the i386 LD variable.

Obtained from: CheriBSD

Test Plan

make tinderbox and verified for amd64 that various warnings about unused arguments disappeared

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Aug 14 2020, 5:29 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptAug 14 2020, 5:29 PM

jhb requested review of this revision.Aug 14 2020, 5:29 PM

Harbormaster completed remote builds in B32997: Diff 75827.Aug 14 2020, 5:29 PM

If it passes universe then +1. I wonder if this was a workaround for bfd or just an old mistake.

This revision is now accepted and ready to land.Aug 14 2020, 10:28 PM

It looks like all of this (putting -L in CFLAGS and an explicit -L (originally a -Y) for the i386 LD all goes back to the original hacks Peter did for lib32 in rS137288.

Closed by commit rS364318: Move -L${LIBCOMPATTMP}/usr/lib${libcompat} from CFLAGS to LDFLAGS. (authored by jhb). · Explain WhyAug 17 2020, 5:17 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS364318: Move -L${LIBCOMPATTMP}/usr/lib${libcompat} from CFLAGS to LDFLAGS..

Herald added a subscriber: imp. · View Herald TranscriptAug 17 2020, 5:17 PM

Revision Contents
Changeset List

Path

Size

head/

share/

mk/

bsd.compat.mk

5 lines

Diff 75900

View Options

head/share/mk/bsd.compat.mk

Move -L${LIBCOMPATTMP}/usr/lib${libcompat} from CFLAGS to LDFLAGS.ClosedPublicActions