Page MenuHomeFreeBSD

Move -L${LIBCOMPATTMP}/usr/lib${libcompat} from CFLAGS to LDFLAGS.
ClosedPublic

Authored by jhb on Aug 14 2020, 5:29 PM.

Details

Summary

This is only needed when linking and fixes various "unused command
line argument" warnings during the lib32 build.

While here, trim a redundant -L from the i386 LD variable.

Obtained from: CheriBSD

Test Plan
  • make tinderbox and verified for amd64 that various warnings about unused arguments disappeared

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Aug 14 2020, 5:29 PM

If it passes universe then +1. I wonder if this was a workaround for bfd or just an old mistake.

This revision is now accepted and ready to land.Aug 14 2020, 10:28 PM

It looks like all of this (putting -L in CFLAGS and an explicit -L (originally a -Y) for the i386 LD all goes back to the original hacks Peter did for lib32 in rS137288.