Improve ECN negotiation when using the TCP SYN-cache
ClosedPublic
Actions

Authored by tuexen on Aug 8 2020, 12:10 PM.

Details

Reviewers

rrs
rscheff

Group Reviewers

transport

Commits

rS364054: Improve the ECN negotiation when the TCP SYN-cache is used by making

Summary

This patch ensures that

ECN is disabled if the client sends an non-ECN-setup SYN segment.
ECN is disabled is the ECN-setup SYN-ACK segment is retransmitted more than net.inet.tcp.ecn.maxretries times.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Aug 8 2020, 12:10 PM

Herald added a reviewer: transport. · View Herald TranscriptAug 8 2020, 12:10 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Aug 8 2020, 12:10 PM

Harbormaster completed remote builds in B32873: Diff 75606.Aug 8 2020, 12:10 PM

Good catch! The fix looks perfect

This revision is now accepted and ready to land.Aug 8 2020, 5:58 PM

Closed by commit rS364054: Improve the ECN negotiation when the TCP SYN-cache is used by making (authored by tuexen). · Explain WhyAug 8 2020, 7:40 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rS364054: Improve the ECN negotiation when the TCP SYN-cache is used by making.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_syncache.c

10 lines

Diff 75612

View Options

head/sys/netinet/tcp_syncache.c

Improve ECN negotiation when using the TCP SYN-cacheClosedPublicActions