Differential D26000

net80211 / ifconfig: cleanup the use of IEEE80211_FVHT_USEVHT*
ClosedPublic
Actions

Authored by bz on Aug 7 2020, 5:43 PM.

Details

Reviewers

adrian

Group Reviewers

wireless

Commits

rS364299: net80211 / ifconfig: cleanup the use of IEEE80211_FVHT_USEVHT*

Summary

Rather then using magic numbers duplicate IEEE80211_FVHT_VHT* in
ifconfig (cleanup of these and other flags used and not exposed by
net80211 should happen later) and use those.
In the kernel this simplifies one ioctl path (the other one currently
relies on individual bit flags being passed in).
We also re-order the 80P80 and 160 flag for 160 to come before 80+80
and more clearly leave the flags as TODO in one of the 160/80+80 cases.

Sponsored by: Rubicon Communications, LLC (d/b/a "Netgate")

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32857
Build 30264: arc lint + arc unit

Event Timeline

bz created this revision.Aug 7 2020, 5:43 PM

Herald added a subscriber: melifaro. · View Herald TranscriptAug 7 2020, 5:43 PM

bz requested review of this revision.Aug 7 2020, 5:43 PM

Harbormaster completed remote builds in B32857: Diff 75584.Aug 7 2020, 5:43 PM

bz added a child revision: D26002: 80211: consistently order 160 and 80+80.Aug 7 2020, 6:16 PM

Anyone? I am planning to commit this next week.

I'm happy with this change although I'd remove the code in #if 0 instead of leaving it there.

sys/net80211/ieee80211_vht.c
164	Any reason to not just remove this code instead of the ifdef 0 ?

adrian accepted this revision.Aug 16 2020, 1:16 AM

adrian added a subscriber: adrian.

adrian added inline comments.

sys/net80211/ieee80211_vht.c
164	when i did the bring up i left a bunch of these TODO FIXMEs around where I found things that needed to be taught about VHT flags. I think it's a good idea to finish this off and implement the vhtcaps check to make sure 40, 80, 80+80 and 160 are used. It shouldn't be /that/ hard.