Differential D25995

Use uintptr_t instead of uint64_t for pointers in stack frames.
ClosedPublic
Actions

Authored by jhb on Aug 7 2020, 4:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 16, 5:13 AM

	Unknown Object (File)
	Wed, Oct 15, 6:05 PM

	Unknown Object (File)
	Wed, Oct 15, 6:05 PM

	Unknown Object (File)
	Wed, Oct 15, 6:05 PM

	Unknown Object (File)
	Wed, Oct 15, 7:32 AM

	Unknown Object (File)
	Sat, Oct 11, 2:49 AM

	Unknown Object (File)
	Thu, Oct 9, 5:07 PM

	Unknown Object (File)
	Thu, Sep 25, 3:14 PM

View All 88 Files

Subscribers

Details

Reviewers

br
mhorne
kp

Commits

rS364180: Use uintptr_t instead of uint64_t for pointers in stack frames.

Test Plan

used in CheriBSD with a kernel which has CHERI capabilities as pointers (so uintptr_t is 128 bits and pointers in the stack are that size, etc.)

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 32849
Build 30258: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Aug 7 2020, 4:12 PM

jhb created this revision.

Harbormaster completed remote builds in B32849: Diff 75575.Aug 7 2020, 4:12 PM

In theory this would be more RV32 friendly as well, though I don't really think we need a FreeBSD/riscv32.

sys/riscv/riscv/unwind.c
54	Note that we are probably using a compressed instruction (c.jalr) so subtracting 4 rather than 2 is not always correct, but it's probably close enough as the intent is to get the right symbol name for tail calls where the saved RA may in fact point to the start of a different function.

mhorne accepted this revision.Aug 9 2020, 3:09 PM

This revision is now accepted and ready to land.Aug 9 2020, 3:09 PM

Closed by commit rS364180: Use uintptr_t instead of uint64_t for pointers in stack frames. (authored by jhb). · Explain WhyAug 12 2020, 8:30 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS364180: Use uintptr_t instead of uint64_t for pointers in stack frames..

Herald added a subscriber: imp. · View Herald TranscriptAug 12 2020, 8:30 PM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

include/

6 lines

riscv/

18 lines

stack_machdep.c

6 lines

6 lines

Diff 75575

sys/riscv/include/stack.h

Loading...

sys/riscv/riscv/db_trace.c

Loading...

sys/riscv/riscv/stack_machdep.c

Loading...

sys/riscv/riscv/unwind.c

Loading...