Page MenuHomeFreeBSD

Clean up reassignbuf() a bit.
ClosedPublic

Authored by markj on Aug 5 2020, 7:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 20 2024, 1:43 AM
Unknown Object (File)
Nov 19 2024, 11:16 PM
Unknown Object (File)
Oct 3 2024, 1:51 AM
Unknown Object (File)
Oct 3 2024, 1:50 AM
Unknown Object (File)
Oct 3 2024, 1:50 AM
Unknown Object (File)
Oct 3 2024, 1:49 AM
Unknown Object (File)
Sep 28 2024, 2:56 PM
Unknown Object (File)
Sep 9 2024, 12:51 AM
Subscribers

Details

Summary
  • Remove the reassignbufcalls sysctl. As the 20-year old comment above it indicates, it does not seem very useful. Also it is not precise and hurts scalability. getnewbufcalls was converted to counter(9), and we could do that here too, but the utility of the counter seems pretty dubious to begin with.
  • Convert some panic() calls into KASSERTs. The pctrie code will panic if it fails to locate the specified key during deletion, so we get some protection if the buf is not present.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Aug 5 2020, 7:16 PM
markj created this revision.
This revision is now accepted and ready to land.Aug 5 2020, 7:24 PM

Side note: I think this should go in as 2 commits.

kib added inline comments.
sys/kern/vfs_subr.c
2720 ↗(On Diff #75443)

BTW this sentence is false for quite long time.

In D25965#575595, @mjg wrote:

Side note: I think this should go in as 2 commits.

Will do.

sys/kern/vfs_subr.c
2720 ↗(On Diff #75443)

Both sentences, I guess.

sys/kern/vfs_subr.c
2720 ↗(On Diff #75443)

Yes, it is used only to reassign between queues now.

Rewrite the reassignbuf() description.

This revision now requires review to proceed.Aug 5 2020, 9:05 PM
This revision is now accepted and ready to land.Aug 5 2020, 9:19 PM
This revision was automatically updated to reflect the committed changes.