Allow bootstrapping mtree on Linux systems
ClosedPublic
Actions

Authored by arichardson on Aug 3 2020, 2:43 PM.

Details

Reviewers

brooks
jhb
emaste

Commits

rS363806: Allow bootstrapping mtree on Linux systems

Summary

Linux glibc has a dummy lchmod that always fails and emitting a linker
warning when used. Don't fail the build due to that warning when
bootstrapping by setting LD_FATAL_WARNINGS=no.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Aug 3 2020, 2:43 PM

arichardson created this revision.

Harbormaster completed remote builds in B32721: Diff 75308.Aug 3 2020, 2:43 PM

This is fine with me, although I wonder if we should just turn off Werror / LD_FATAL_WARNINGS etc. completely in the cross-bootstrapping case?

brooks accepted this revision.Aug 3 2020, 5:03 PM

This revision is now accepted and ready to land.Aug 3 2020, 5:03 PM

emaste accepted this revision.Aug 3 2020, 5:08 PM

Closed by commit rS363806: Allow bootstrapping mtree on Linux systems (authored by arichardson). · Explain WhyAug 3 2020, 6:08 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS363806: Allow bootstrapping mtree on Linux systems.

Herald added a subscriber: imp. · View Herald TranscriptAug 3 2020, 6:08 PM

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

nmtree/

Makefile

6 lines

Diff 75323

View Options

head/usr.sbin/nmtree/Makefile

Allow bootstrapping mtree on Linux systemsClosedPublicActions