Differential D25929

Allow building setmode.c on Linux/macOS
ClosedPublic
Actions

Authored by arichardson on Aug 3 2020, 2:41 PM.

Tags

None

Referenced Files

	F137969043: D25929.id75322.diff
	Thu, Nov 27, 6:43 PM

	Unknown Object (File)
	Wed, Nov 26, 9:11 PM

	Unknown Object (File)
	Tue, Nov 25, 12:12 PM

	Unknown Object (File)
	Fri, Nov 21, 2:42 AM

	Unknown Object (File)
	Fri, Nov 21, 2:40 AM

	Unknown Object (File)
	Fri, Nov 21, 2:38 AM

	Unknown Object (File)
	Fri, Nov 21, 2:35 AM

	Unknown Object (File)
	Fri, Nov 21, 2:32 AM

Subscribers

Details

Reviewers

brooks
emaste
jhb

Commits

rS363805: Allow building setmode.c on Linux/macOS

Summary

We bootstrap this file to allow compiling FreeBSD on Linux systems since
some boostrap tools use setmode(). Unfortunately, glibc's sys/stat.h
declares a non-static getumask() function (which is unimplemented!) and
that conflicts with the local getumask() function. To work around this
simply use a different name here.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32720
Build 30164: arc lint + arc unit

Event Timeline

arichardson requested review of this revision.Aug 3 2020, 2:41 PM

arichardson created this revision.

Harbormaster completed remote builds in B32719: Diff 75306.Aug 3 2020, 2:41 PM

remove file that wasn't intended for this change

Harbormaster completed remote builds in B32720: Diff 75307.Aug 3 2020, 2:42 PM

OK, this is sufficiently unobtrusive

This revision is now accepted and ready to land.Aug 3 2020, 3:00 PM

brooks accepted this revision.Aug 3 2020, 5:02 PM

Closed by commit rS363805: Allow building setmode.c on Linux/macOS (authored by arichardson). · Explain WhyAug 3 2020, 6:08 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS363805: Allow building setmode.c on Linux/macOS.

Herald added a subscriber: imp. · View Herald TranscriptAug 3 2020, 6:08 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

9 lines

Diff 75307

lib/libc/gen/setmode.c

Loading...