Correctly set error in rt_mpath_unlink
ClosedPublic
Actions

Authored by mhorne on Jul 28 2020, 9:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 6, 2:23 AM

	Unknown Object (File)
	Wed, Nov 5, 8:24 PM

	Unknown Object (File)
	Sun, Nov 2, 1:51 PM

	Unknown Object (File)
	Wed, Oct 29, 3:14 AM

	Unknown Object (File)
	Wed, Oct 29, 2:00 AM

	Unknown Object (File)
	Mon, Oct 20, 6:31 AM

	Unknown Object (File)
	Oct 8 2025, 10:01 AM

	Unknown Object (File)
	Oct 7 2025, 5:23 AM

Subscribers

Details

Reviewers

melifaro
thj

Commits

rS364172: Correctly set error in rt_mpath_unlink

Summary

It is possible for rn_delete() to return NULL in certain cases. If this
happens then rt_mpath_unlink() should set *perror to ESRCH, as it does
in all other cases where it fails to find a radix_node.

Test Plan

buildkernel with RADIX_MPATH added to the kernel configuration

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Jul 28 2020, 9:10 PM

Herald added a subscriber: ae. · View Herald TranscriptJul 28 2020, 9:10 PM

Harbormaster completed remote builds in B32629: Diff 75094.Jul 28 2020, 9:10 PM

mhorne requested review of this revision.Jul 28 2020, 9:10 PM

siderop1_netapp.com added a subscriber: siderop1_netapp.com.Jul 28 2020, 10:06 PM

allanjude added a reviewer: thj.Aug 1 2020, 7:49 PM

Hi, any opposition to this?

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:43 PM

Closed by commit rS364172: Correctly set error in rt_mpath_unlink (authored by mhorne). · Explain Why

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rS364172: Correctly set error in rt_mpath_unlink.

Herald added a subscriber: imp. · View Herald TranscriptAug 12 2020, 4:43 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

route.c

6 lines

Diff 75735

View Options

Correctly set error in rt_mpath_unlinkClosedPublicActions