Differential D25868

Remove most lingering references to the page lock in comments.
ClosedPublic
Actions

Authored by markj on Jul 28 2020, 8:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 13, 12:26 PM

	Unknown Object (File)
	Mon, Nov 4, 3:06 AM

	Unknown Object (File)
	Mon, Nov 4, 3:06 AM

	Unknown Object (File)
	Mon, Nov 4, 3:04 AM

	Unknown Object (File)
	Mon, Nov 4, 3:04 AM

	Unknown Object (File)
	Mon, Nov 4, 2:44 AM

	Unknown Object (File)
	Oct 21 2024, 1:58 PM

	Unknown Object (File)
	Oct 11 2024, 5:18 AM

View All 52 Files

Subscribers

Details

Reviewers

alc
jeff
dougm
kib

Commits

rS363840: Remove most lingering references to the page lock in comments.

Summary

Finish updating comments to reflect new locking protocols introduced
over the past year. In particular, vm_page_lock is effectively unused
now. This diff does not modify comments relating to the busy lock,
which has also changed in scope.

There is one remaining comment that references the page lock, omitted
here because it corresponds to a (mostly harmless) bug in r356157. I
will fix it separately.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj requested review of this revision.Jul 28 2020, 8:03 PM

markj created this revision.

Harbormaster completed remote builds in B32627: Diff 75091.Jul 28 2020, 8:03 PM

markj added reviewers: alc, jeff, dougm, kib.Jul 28 2020, 8:03 PM

kib added inline comments.Jul 29 2020, 11:38 AM

sys/vm/vm_page.c
3800 ↗	(On Diff #75091)	xbusied
4259 ↗	(On Diff #75091)	This comments literally reflects asserts, I am not sure if it is useful.

Address feedback.

Harbormaster completed remote builds in B32646: Diff 75125.Jul 29 2020, 2:22 PM

kib accepted this revision.Jul 29 2020, 2:56 PM

This revision is now accepted and ready to land.Jul 29 2020, 2:56 PM

Closed by commit rS363840: Remove most lingering references to the page lock in comments. (authored by markj). · Explain WhyAug 4 2020, 2:59 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS363840: Remove most lingering references to the page lock in comments..

Herald added a subscriber: imp. · View Herald TranscriptAug 4 2020, 2:59 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

35 lines

19 lines

7 lines

2 lines

Diff 75368

head/sys/vm/vm_page.h

Loading...

head/sys/vm/vm_page.c

Loading...

head/sys/vm/vm_pageout.c

Loading...

head/sys/vm/vnode_pager.c

Loading...