Page MenuHomeFreeBSD
Differential D25868

Remove most lingering references to the page lock in comments.
ClosedPublic
Actions

Authored by markj on Jul 28 2020, 8:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 11:08 AM
Unknown Object (File)
Feb 20 2024, 3:33 PM
Unknown Object (File)
Dec 20 2023, 8:11 AM
Unknown Object (File)
Nov 14 2023, 2:45 AM
Unknown Object (File)
Nov 2 2023, 3:22 AM
Unknown Object (File)
Oct 13 2023, 1:46 AM
Unknown Object (File)
Oct 4 2023, 8:19 AM
Unknown Object (File)
Oct 1 2023, 3:24 AM
View All 19 Files
Subscribers
imp

Details

Reviewers
alc
jeff
dougm
kib
Commits
rS363840: Remove most lingering references to the page lock in comments.
Summary

Finish updating comments to reflect new locking protocols introduced
over the past year. In particular, vm_page_lock is effectively unused
now. This diff does not modify comments relating to the busy lock,
which has also changed in scope.

There is one remaining comment that references the page lock, omitted
here because it corresponds to a (mostly harmless) bug in r356157. I
will fix it separately.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32646
Build 30099: arc lint + arc unit

Event Timeline

markj requested review of this revision.Jul 28 2020, 8:03 PM
markj created this revision.
Harbormaster completed remote builds in B32627: Diff 75091.Jul 28 2020, 8:03 PM
markj added reviewers: alc, jeff, dougm, kib.Jul 28 2020, 8:03 PM
kib added inline comments.Jul 29 2020, 11:38 AM
sys/vm/vm_page.c
3800–3801

xbusied

4257–4258

This comments literally reflects asserts, I am not sure if it is useful.

markj updated this revision to Diff 75125.Jul 29 2020, 2:22 PM
markj marked 2 inline comments as done.

Address feedback.

Harbormaster completed remote builds in B32646: Diff 75125.Jul 29 2020, 2:22 PM
kib accepted this revision.Jul 29 2020, 2:56 PM
This revision is now accepted and ready to land.Jul 29 2020, 2:56 PM
Closed by commit rS363840: Remove most lingering references to the page lock in comments. (authored by markj). · Explain WhyAug 4 2020, 2:59 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS363840: Remove most lingering references to the page lock in comments..
Herald added a subscriber: imp. · View Herald TranscriptAug 4 2020, 2:59 PM

Revision Contents
Changeset List

PathSize
sys/
vm/
35 lines
19 lines
7 lines
2 lines

Diff 75125

View Options

sys/vm/vm_page.h

Loading...
View Options

sys/vm/vm_page.c

Loading...
View Options

sys/vm/vm_pageout.c

Loading...
View Options

sys/vm/vnode_pager.c

Loading...