Page MenuHomeFreeBSD

ng_iface(4): Remove unsupported protocols.
ClosedPublic

Authored by markj on Tue, Jul 28, 3:29 PM.

Details

Summary

Support for non-IPv4 and v6 hooks was removed long ago.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj created this revision.Tue, Jul 28, 3:29 PM
markj requested review of this revision.Tue, Jul 28, 3:29 PM
markj edited the summary of this revision. (Show Details)Tue, Jul 28, 3:29 PM
markj added a reviewer: lutz_donnerhacke.de.

What's the reason behind this proposal?

You remove a possible functionality (which is provided by other players) for the gain of couple of bytes in a static table and a slightly shorter man page.
Of course there private data field will become a bit shorter, too.

Why do you keep the definitions of these constants in ng_iface.h? Are there any other consumers?

Îf you want to stay in touch with the kernel capabilities, please consider a dynamic hook management which obtains the valid address family names from the real kernel table. This way, any change in the kernel supported protocols would be automatically available on the ng_iface.

markj added a comment.Tue, Jul 28, 9:52 PM

What's the reason behind this proposal?

The documentation is incorrect. I wish to correct it. And if I do that I see no reason to keep around dead hooks either, so I removed them.

You remove a possible functionality (which is provided by other players) for the gain of couple of bytes in a static table and a slightly shorter man page.
Of course there private data field will become a bit shorter, too.

The actual functionality was removed a long time ago and has not come back. Sure, this is not a significant change, but I noticed the disparity when reading ng_iface and see no reason to leave it that way.

Why do you keep the definitions of these constants in ng_iface.h?

I missed them, thanks.

Are there any other consumers?

Nothing in the base system it seems.

Îf you want to stay in touch with the kernel capabilities, please consider a dynamic hook management which obtains the valid address family names from the real kernel table. This way, any change in the kernel supported protocols would be automatically available on the ng_iface.

markj updated this revision to Diff 75096.Tue, Jul 28, 9:53 PM

Update ng_iface.h as well.

This revision is now accepted and ready to land.Tue, Jul 28, 11:00 PM
This revision was automatically updated to reflect the committed changes.