Page MenuHomeFreeBSD

Pass the full CFLAGS to cpp for MKlib_gen.sh.
ClosedPublic

Authored by jhb on Jul 19 2020, 8:47 PM.
Tags
None
Referenced Files
F166436587: D25731.diff
Thu, Aug 13, 1:54 PM
Unknown Object (File)
Sun, Jul 26, 6:32 AM
Unknown Object (File)
Fri, Jul 24, 3:46 PM
Unknown Object (File)
Wed, Jul 15, 1:03 PM
Unknown Object (File)
Jul 14 2026, 3:50 PM
Unknown Object (File)
Jul 9 2026, 8:34 AM
Unknown Object (File)
Jun 29 2026, 9:40 PM
Unknown Object (File)
Jun 28 2026, 1:58 AM
Subscribers

Details

Summary

GCC's cpp was exiting when it failed to find requested includes
(<ncurses_cfg.h> and <ncurses_defs.h>). clang-cpp just silently
ignored the missing header files (thus not honoring any macros
defined in those).

Test Plan
  • build worlds with amd64-gcc and aarch64-gcc which failed to link lldb since libc_gen.c was empty and lldb links against box()

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jul 19 2020, 8:47 PM
jhb created this revision.

This is a regression introduced earlier this year in an ncurses upgrade when this was switched to using CPP + CPPFLAGS (which is always empty) instead of CC + CFLAGS (which the other generated files still use?). The fact that clang-cpp silently fails and ignores errors seems like a bug in clang-cpp to me.

kevans added a subscriber: kevans.

LGTM and explains what I had observed when looking at this a couple weeks ago.

This revision is now accepted and ready to land.Aug 3 2020, 4:27 PM
This revision was automatically updated to reflect the committed changes.