Page MenuHomeFreeBSD
Differential D25696

crypto(9): Remove some unnecessary error handling.
ClosedPublic
Actions

Authored by markj on Jul 16 2020, 8:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 3:48 AM
Unknown Object (File)
Fri, Oct 10, 2:59 AM
Unknown Object (File)
Fri, Sep 26, 2:38 AM
Unknown Object (File)
Wed, Sep 24, 12:34 AM
Unknown Object (File)
Sep 12 2025, 9:39 PM
Unknown Object (File)
Sep 8 2025, 7:55 AM
Unknown Object (File)
Sep 5 2025, 2:50 PM
Unknown Object (File)
Aug 29 2025, 6:07 PM
View All 66 Files
Subscribers
imp

Details

Reviewers
cem
jhb
delphij
jmg
Commits
rS363273: Clean up crypto_init().
Summary

crypto_init() is called from a module load handler and is thus allowed
to sleep. So:

  • uma_zcreate() doesn't fail, so stop handling failures
  • stop handling M_WAITOK allocation failures
  • convert M_NOWAIT allocations in crypto_init() to M_WAITOK
  • fix some style bugs in crypto_init()

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Jul 16 2020, 8:43 PM
markj created this revision.
Harbormaster completed remote builds in B32372: Diff 74545.Jul 16 2020, 8:43 PM
markj added reviewers: cem, jhb, delphij.Jul 16 2020, 8:50 PM
delphij accepted this revision.Jul 16 2020, 9:06 PM
delphij added inline comments.
sys/opencrypto/crypto.c
328 ↗(On Diff #74545)

[OPTIONAL] This should probably go in a different changeset, but I'm fine if it's left as-is too.

This revision is now accepted and ready to land.Jul 16 2020, 9:06 PM
jhb accepted this revision.Jul 16 2020, 11:12 PM
jhb added inline comments.
sys/opencrypto/cryptodev.c
1318 ↗(On Diff #74545)

This one isn't crypto_init(), so I would perhaps commit it separately?

cem accepted this revision.Jul 16 2020, 11:34 PM
markj added inline comments.Jul 17 2020, 2:27 PM
sys/opencrypto/crypto.c
328 ↗(On Diff #74545)

Since the whole thing is trivial cleanup, I tend to prefer just a single commit.

sys/opencrypto/cryptodev.c
1318 ↗(On Diff #74545)

Ok. This bit actually comes from PR 240545.

Closed by commit rS363273: Clean up crypto_init(). (authored by markj). · Explain WhyJul 17 2020, 2:45 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS363273: Clean up crypto_init()..
Herald added a reviewer: jmg. · View Herald TranscriptJul 17 2020, 2:45 PM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
head/
sys/
opencrypto/
40 lines

Diff 74575

View Options

head/sys/opencrypto/crypto.c

Loading...