Page MenuHomeFreeBSD
Differential D25636

Make linux(4) support splice(2) - kind of
ClosedPublic
Actions

Authored by trasz on Jul 12 2020, 3:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 8, 6:20 PM
Unknown Object (File)
Wed, Apr 8, 3:24 AM
Unknown Object (File)
Sat, Apr 4, 9:40 PM
Unknown Object (File)
Wed, Mar 25, 5:58 PM
Unknown Object (File)
Tue, Mar 24, 8:40 PM
Unknown Object (File)
Tue, Mar 24, 8:19 AM
Unknown Object (File)
Tue, Mar 24, 3:50 AM
Unknown Object (File)
Sun, Mar 22, 6:25 PM
View All Files
Subscribers
andrew
emaste
imp

Details

Reviewers
brooks
manu
emaste
Group Reviewers
Linux Emulation
Commits
rS363304: Add a trivial linux(4) splice(2) implementation, which simply
Summary

Add a trivial linux(4) splice(2) implementation, which simply
returns EINVAL. Fixes grep (grep-3.1-2build1).

PR: kern/247219

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.Jul 12 2020, 3:24 PM
Herald added a reviewer: brooks. · View Herald TranscriptJul 12 2020, 3:24 PM
Herald added a subscriber: imp. · View Herald Transcript
trasz requested review of this revision.Jul 12 2020, 3:24 PM
Harbormaster completed remote builds in B32276: Diff 74359.Jul 12 2020, 3:24 PM
trasz updated this revision to Diff 74360.Jul 12 2020, 3:26 PM

Upload the right diff.

Harbormaster completed remote builds in B32277: Diff 74360.Jul 12 2020, 3:26 PM
trasz added a reviewer: Linux Emulation.Jul 12 2020, 3:27 PM
trasz updated this revision to Diff 74361.Jul 12 2020, 3:29 PM

Add arm64.

Herald added a reviewer: manu. · View Herald TranscriptJul 12 2020, 3:29 PM
Herald added subscribers: emaste, andrew. · View Herald Transcript
Harbormaster completed remote builds in B32278: Diff 74361.Jul 12 2020, 3:29 PM
trasz added a comment.Jul 13 2020, 3:24 PM

(Tinderboxed.)

emaste added inline comments.Jul 13 2020, 3:29 PM
sys/compat/linux/linux_file.c
1774 ↗(On Diff #74361)

so consumers handle EINVAL from splice but not ENOSYS?

trasz added inline comments.Jul 13 2020, 10:04 PM
sys/compat/linux/linux_file.c
1774 ↗(On Diff #74361)

Precisely. Well, the one I found: grep. But looking at splice(2) man page, consumers probably need to handle it anyway: with early kernels exactly one of the fds had to be a pipe, later both could be, then there's "EINVAL The target filesystem doesn't support splicing"...

emaste accepted this revision.Jul 14 2020, 12:58 AM

Probably worth putting that EINVAL description in a comment by the return.

This revision is now accepted and ready to land.Jul 14 2020, 12:58 AM
Closed by commit rS363304: Add a trivial linux(4) splice(2) implementation, which simply (authored by trasz). · Explain WhyJul 18 2020, 11:29 AM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS363304: Add a trivial linux(4) splice(2) implementation, which simply.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
linux/
1 line
9 lines
linux32/
1 line
9 lines
arm64/
linux/
1 line
9 lines
compat/
linux/
14 lines
i386/
linux/
1 line
9 lines

Diff 74614

View Options

head/sys/amd64/linux/linux_dummy.c

Loading...
View Options

head/sys/amd64/linux/syscalls.master

Loading...
View Options

head/sys/amd64/linux32/linux32_dummy.c

Loading...
View Options

head/sys/amd64/linux32/syscalls.master

Loading...
View Options

head/sys/arm64/linux/linux_dummy.c

Loading...
View Options

head/sys/arm64/linux/syscalls.master

Loading...
View Options

head/sys/compat/linux/linux_file.c

Loading...
View Options

head/sys/i386/linux/linux_dummy.c

Loading...
View Options

head/sys/i386/linux/syscalls.master

Loading...