Page MenuHomeFreeBSD

Make linux(4) support splice(2) - kind of
ClosedPublic

Authored by trasz on Jul 12 2020, 3:24 PM.

Details

Summary

Add a trivial linux(4) splice(2) implementation, which simply
returns EINVAL. Fixes grep (grep-3.1-2build1).

PR: kern/247219

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

trasz requested review of this revision.Jul 12 2020, 3:24 PM
sys/compat/linux/linux_file.c
1774 ↗(On Diff #74361)

so consumers handle EINVAL from splice but not ENOSYS?

sys/compat/linux/linux_file.c
1774 ↗(On Diff #74361)

Precisely. Well, the one I found: grep. But looking at splice(2) man page, consumers probably need to handle it anyway: with early kernels exactly one of the fds had to be a pipe, later both could be, then there's "EINVAL The target filesystem doesn't support splicing"...

Probably worth putting that EINVAL description in a comment by the return.

This revision is now accepted and ready to land.Jul 14 2020, 12:58 AM