Paths

Table of Contentst

Differential D25636

Make linux(4) support splice(2) - kind of
ClosedPublic
Actions

Authored by trasz on Jul 12 2020, 3:24 PM.

Tags

None

Referenced Files

	F132587187: D25636.id74359.diff
	Sat, Oct 18, 5:04 AM

	F132587181: D25636.id.diff
	Sat, Oct 18, 5:04 AM

	F132534840: D25636.id74361.diff
	Fri, Oct 17, 6:34 PM

	F132534831: D25636.id74360.diff
	Fri, Oct 17, 6:34 PM

	F132534828: D25636.id74614.diff
	Fri, Oct 17, 6:34 PM

	Unknown Object (File)
	Fri, Oct 17, 9:42 AM

	Unknown Object (File)
	Sat, Oct 11, 6:47 AM

	Unknown Object (File)
	Sun, Oct 5, 11:11 AM

Subscribers

Details

Reviewers

brooks
manu
emaste

Group Reviewers

Linux Emulation

Commits

rS363304: Add a trivial linux(4) splice(2) implementation, which simply

Summary

Add a trivial linux(4) splice(2) implementation, which simply
returns EINVAL. Fixes grep (grep-3.1-2build1).

PR: kern/247219

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Jul 12 2020, 3:24 PM

Herald added a reviewer: brooks. · View Herald TranscriptJul 12 2020, 3:24 PM

Herald added a subscriber: imp. · View Herald Transcript

trasz requested review of this revision.Jul 12 2020, 3:24 PM

Harbormaster completed remote builds in B32276: Diff 74359.Jul 12 2020, 3:24 PM

Upload the right diff.

Harbormaster completed remote builds in B32277: Diff 74360.Jul 12 2020, 3:26 PM

trasz added a reviewer: Linux Emulation.Jul 12 2020, 3:27 PM

Add arm64.

Herald added a reviewer: manu. · View Herald TranscriptJul 12 2020, 3:29 PM

Herald added subscribers: emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B32278: Diff 74361.Jul 12 2020, 3:29 PM

(Tinderboxed.)

emaste added inline comments.Jul 13 2020, 3:29 PM

sys/compat/linux/linux_file.c
1774 ↗	(On Diff #74361)	so consumers handle `EINVAL` from splice but not `ENOSYS`?

trasz added inline comments.Jul 13 2020, 10:04 PM

sys/compat/linux/linux_file.c
1774 ↗	(On Diff #74361)	Precisely. Well, the one I found: grep. But looking at splice(2) man page, consumers probably need to handle it anyway: with early kernels exactly one of the fds had to be a pipe, later both could be, then there's "EINVAL The target filesystem doesn't support splicing"...

Probably worth putting that EINVAL description in a comment by the return.

This revision is now accepted and ready to land.Jul 14 2020, 12:58 AM

Closed by commit rS363304: Add a trivial linux(4) splice(2) implementation, which simply (authored by trasz). · Explain WhyJul 18 2020, 11:29 AM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS363304: Add a trivial linux(4) splice(2) implementation, which simply.

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

linux/

1 line

syscalls.master

9 lines

linux32/

linux32_dummy.c

1 line

syscalls.master

9 lines

arm64/

linux/

1 line

syscalls.master

9 lines

compat/

linux/

14 lines

i386/

linux/

1 line

syscalls.master

9 lines

Diff 74614

head/sys/amd64/linux/linux_dummy.c

Loading...

head/sys/amd64/linux/syscalls.master

Loading...

head/sys/amd64/linux32/linux32_dummy.c

Loading...

head/sys/amd64/linux32/syscalls.master

Loading...

head/sys/arm64/linux/linux_dummy.c

Loading...

head/sys/arm64/linux/syscalls.master

Loading...

head/sys/compat/linux/linux_file.c

Loading...

head/sys/i386/linux/linux_dummy.c

Loading...

head/sys/i386/linux/syscalls.master

Loading...