Page MenuHomeFreeBSD

iflib: Fix some nits in the rx refill code.
ClosedPublic

Authored by markj on Jun 27 2020, 3:36 PM.

Details

Summary


- Get rid of the ifl_vm_addrs array. It is not used by any existing
consumer, so we are just dirtying a couple of cache lines for no
reason.
- Use uma_zalloc(fl->ifl_zone) instead of m_cljget(). Otherwise
m_cljget() is doing unnecessary work to look up the correct zone, when
iflib already knows what that zone is.
- ifl_gen is only used when INVARIANTS is on, so make that more clear.
- Fix some style nits and inconsistencies.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj requested review of this revision.Jun 27 2020, 3:36 PM
gallatin added a subscriber: gallatin.

Great work. There are *so many* of these optimizations hiding in this code. I'm really glad you're looking at it.

This revision is now accepted and ready to land.Jun 29 2020, 4:59 PM
This revision was automatically updated to reflect the committed changes.