Page MenuHomeFreeBSD
Differential D25488

Document new kern.tty_info_kstacks tunable.
ClosedPublic
Actions

Authored by grembo on Jun 27 2020, 2:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 5:02 PM
Unknown Object (File)
Wed, Dec 4, 11:02 AM
Unknown Object (File)
Wed, Dec 4, 11:02 AM
Unknown Object (File)
Wed, Dec 4, 11:02 AM
Unknown Object (File)
Wed, Dec 4, 11:01 AM
Unknown Object (File)
Wed, Dec 4, 10:42 AM
Unknown Object (File)
Sep 29 2024, 2:20 AM
Unknown Object (File)
Sep 27 2024, 4:26 PM
View All 72 Files
Subscribers
0mp
imp

Details

Reviewers
jhb
0mp
imp
Group Reviewers
manpages
Commits
rS362727: Adapt documentation of kern.tty_info_kstacks.
rS362700: Document new kern.tty_info_kstacks tunable.
Summary

This new and useful tunable was introduced recently, document
on the termios man page (which, by the way, does a great job
hiding that this is usually ^T).

Test Plan

mandoc -T lint
igor

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32014
Build 29548: arc lint + arc unit

Event Timeline

grembo created this revision.Jun 27 2020, 2:48 PM
Herald added a reviewer: manpages. · View Herald TranscriptJun 27 2020, 2:48 PM
Herald added a subscriber: imp. · View Herald Transcript
grembo requested review of this revision.Jun 27 2020, 2:48 PM
Harbormaster completed remote builds in B32011: Diff 73771.Jun 27 2020, 2:48 PM
0mp accepted this revision.Jun 27 2020, 2:53 PM
0mp added a subscriber: 0mp.

Otherwise, looks nice.

share/man/man4/termios.4
770

How do you feel about this little change?

This revision is now accepted and ready to land.Jun 27 2020, 2:53 PM
grembo added a comment.Jun 27 2020, 2:58 PM

Screen shot

termios_man.png (382×940 px, 42 KB)

share/man/man4/termios.4
770

In general I have no feelings about it, both work for me. If there's another void that prefers that, I'll change it ;)

imp accepted this revision.Jun 27 2020, 3:32 PM

Either of the proposed text changes sound good to me.

grembo updated this revision to Diff 73774.Jun 27 2020, 3:39 PM

Change wording as proposed by 0mp

This revision now requires review to proceed.Jun 27 2020, 3:39 PM
Harbormaster completed remote builds in B32014: Diff 73774.Jun 27 2020, 3:39 PM
grembo marked an inline comment as done.Jun 27 2020, 3:40 PM
In D25488#562868, @imp wrote:

Either of the proposed text changes sound good to me.

Which makes it two voices (not voids), I'll change it to what @0mp proposed.

0mp accepted this revision.Jun 27 2020, 3:45 PM
This revision is now accepted and ready to land.Jun 27 2020, 3:45 PM
Closed by commit rS362700: Document new kern.tty_info_kstacks tunable. (authored by grembo). · Explain WhyJun 27 2020, 4:31 PM
This revision was automatically updated to reflect the committed changes.
grembo added a commit: rS362700: Document new kern.tty_info_kstacks tunable..
jhb added inline comments.Jun 27 2020, 6:08 PM
head/share/man/man4/termios.4
769 ↗(On Diff #73778)

s/stack/kernel stack/. This does not show user stacks (though I think the original committer has local changes in OneFS that do that) only kernel stacks.

grembo marked an inline comment as done.Jun 28 2020, 5:28 PM
grembo added a commit: rS362727: Adapt documentation of kern.tty_info_kstacks..
grembo added a comment.Jun 28 2020, 5:28 PM

@jhb Thanks

Revision Contents
Changeset List

PathSize
share/
man/
man4/
12 lines

Diff 73774

View Options

share/man/man4/termios.4

Loading...