Correct menu title: keyboards have a layout, not a language
ClosedPublic
Actions

Authored by emaste on May 14 2015, 2:43 PM.

Details

Reviewers

trasz
bapt

Commits

rS282914: kbdmap(1): Correct menu title: keyboards have a layout, not a language

Summary

I will update this review with improvements for other languages as I receive them.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 5383.May 14 2015, 2:43 PM

emaste retitled this revision from to Correct menu title: keyboards have a layout, not a language.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a subscriber: bapt.May 14 2015, 3:01 PM

emaste added inline comments.

share/vt/keymaps/INDEX.keymaps
26	`Choisissez la disposition de votre clavier`?

update fr text
use "В" instead of "B" in uk text

emaste marked an inline comment as done.May 14 2015, 3:12 PM

emaste added inline comments.

share/vt/keymaps/INDEX.keymaps
31	@kostikbel there was a `B` here before, instead of `В`. Is this text now good, or does it have a similar issue to the one fixed in English/French above?

royger added a subscriber: royger.May 14 2015, 3:24 PM

royger added inline comments.

share/vt/keymaps/INDEX.keymaps
29	This should be: MENU:es:Seleccione la disposición de su teclado

I think the textbook-compliant text would be "Оберiть розкладку клавіатури"

Good for french version

This revision is now accepted and ready to land.May 14 2015, 3:35 PM

Polish text looks fine.

Closed by commit rS282914: kbdmap(1): Correct menu title: keyboards have a layout, not a language (authored by emaste). · Explain WhyMay 14 2015, 6:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

share/

vt/

keymaps/

INDEX.keymaps

2 lines

Diff 5383

View Options

share/vt/keymaps/INDEX.keymaps

Correct menu title: keyboards have a layout, not a languageClosedPublicActions