Page MenuHomeFreeBSD

Add WITH_CLANG_FORMAT option
ClosedPublic

Authored by cem on Wed, Jun 24, 4:32 PM.

Details

Summary

clang-format is enabled conditional on either WITH_CLANG_EXTRAS or
WITH_CLANG_FORMAT. Some sources in libclang are build conditional on
either rule, and obviously the clang-format binary itself depends on the
rule.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cem created this revision.Wed, Jun 24, 4:32 PM
cem requested review of this revision.Wed, Jun 24, 4:32 PM
emaste accepted this revision.Wed, Jun 24, 4:35 PM
emaste added a subscriber: dim.

LGTM

lib/clang/libclang/Makefile
25 ↗(On Diff #73580)

EXTRAS || FORMAT for alpha order?

This revision is now accepted and ready to land.Wed, Jun 24, 4:36 PM

Also add a WITH_CLANG_FORMAT text description file

cem updated this revision to Diff 73581.Wed, Jun 24, 4:39 PM
cem marked an inline comment as done.

Reorder EXTRAS, FORMAT

Add WITH_CLANG_FORMAT file

This revision now requires review to proceed.Wed, Jun 24, 4:39 PM
emaste accepted this revision.Wed, Jun 24, 4:48 PM
This revision is now accepted and ready to land.Wed, Jun 24, 4:48 PM
This revision was automatically updated to reflect the committed changes.