oce(4): Account and trace mbufs before handing to hw
ClosedPublic
Actions

Authored by cem on Jun 19 2020, 8:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 2, 6:08 PM

	Unknown Object (File)
	Sun, Nov 30, 12:07 PM

	Unknown Object (File)
	Sat, Nov 29, 8:52 AM

	Unknown Object (File)
	Thu, Nov 27, 9:10 PM

	Unknown Object (File)
	Mon, Nov 24, 12:11 PM

	Unknown Object (File)
	Sun, Nov 23, 2:59 AM

	Unknown Object (File)
	Sat, Nov 22, 8:52 PM

	Unknown Object (File)
	Thu, Nov 20, 10:36 PM

View All Files

Subscribers

imp

Details

Reviewers

rstone
markj
kevans

Commits

rS362439: oce(4): Account and trace mbufs before handing to hw

Summary

Once tx mbufs have been handed to hardware, nothing serializes the tx
path against completion and potential use-after-free of the outbound
mbuf. Perform accounting and BPF tap before queueing to hardware to
avoid this race.

Submitted by: Steve Wirtz <steve_wirtz AT dell.com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem requested review of this revision.Jun 19 2020, 8:50 PM

cem created this revision.

Harbormaster completed remote builds in B31835: Diff 73354.Jun 19 2020, 8:51 PM

markj accepted this revision.Jun 20 2020, 12:31 AM

This revision is now accepted and ready to land.Jun 20 2020, 12:31 AM

rstone accepted this revision.Jun 20 2020, 5:04 PM

Closed by commit rS362439: oce(4): Account and trace mbufs before handing to hw (authored by cem). · Explain WhyJun 20 2020, 5:23 PM

This revision was automatically updated to reflect the committed changes.

cem added a commit: rS362439: oce(4): Account and trace mbufs before handing to hw.

Herald added a subscriber: imp. · View Herald TranscriptJun 20 2020, 5:23 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

oce/

oce_if.c

18 lines

Diff 73398

View Options

oce(4): Account and trace mbufs before handing to hwClosedPublicActions