Store the AAD in a separate buffer for KTLS.
ClosedPublic
Actions

Authored by jhb on Jun 15 2020, 10:54 PM.

Details

Reviewers

cem
gallatin
jmg

Commits

rS362523: Store the AAD in a separate buffer for KTLS.

Summary

For TLS 1.2 this permits reusing one of the existing iovecs without always
having to duplicate both.

While here, only duplicate the output iovec for TLS 1.3 if it will be used.

Test Plan

tested with TLS 1.2/1.3 with aesni0, soft, and ccr0

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jun 15 2020, 10:54 PM

jhb created this revision.

Harbormaster completed remote builds in B31730: Diff 73157.Jun 15 2020, 10:55 PM

jhb added a parent revision: D25288: Add support to the crypto framework for separate AAD buffers..Jun 15 2020, 10:55 PM

This did not make any meaningful difference for KTLS TX, but I primarily worked on this for the RX case where it means I will be able to pass an mbuf down directly to a backend and skip all the iovec stuff completely.

gallatin accepted this revision.Jun 19 2020, 8:40 PM

This revision is now accepted and ready to land.Jun 19 2020, 8:40 PM

Closed by commit rS362523: Store the AAD in a separate buffer for KTLS. (authored by jhb). · Explain WhyJun 23 2020, 12:02 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS362523: Store the AAD in a separate buffer for KTLS..

Herald added a reviewer: jmg. · View Herald TranscriptJun 23 2020, 12:02 AM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

head/

sys/

opencrypto/

ktls_ocf.c

113 lines

Diff 73487

View Options

head/sys/opencrypto/ktls_ocf.c

Store the AAD in a separate buffer for KTLS.ClosedPublicActions