Page MenuHomeFreeBSD
Differential D25286

ifconfig does not honor disabling vlanhwtag
ClosedPublic
Actions

Authored by vmaffione on Jun 15 2020, 8:12 PM.
Tags
None
Referenced Files
F132569498: D25286.id.diff
Sat, Oct 18, 1:37 AM
F132569476: D25286.id73148.diff
Sat, Oct 18, 1:36 AM
F132569474: D25286.id75528.diff
Sat, Oct 18, 1:36 AM
Unknown Object (File)
Fri, Oct 17, 3:40 PM
Unknown Object (File)
Wed, Oct 15, 1:44 PM
Unknown Object (File)
Wed, Oct 8, 1:45 PM
Unknown Object (File)
Wed, Sep 24, 2:15 AM
Unknown Object (File)
Sep 18 2025, 5:22 AM
View All 91 Files
Subscribers
g.lettieri_iet.unipi.it
imp

Details

Reviewers
erj
gallatin
Group Reviewers
Intel Networking
Commits
rS364879: MFC r363995
rS364878: MFC r363995
rS363995: em(4): honor vlanhwtag offload
Summary

The FreeBSD em driver fails to properly reset the VME flag in the e1000 CTRL register during the following ifconfig command

ifconfig em1 -vlanhwtag

at least on the e1000 device as emulated by QEMU

https://github.com/luigirizzo/netmap/issues/703
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236584

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 31723

Event Timeline

vmaffione created this revision.Jun 15 2020, 8:12 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 15 2020, 8:12 PM
vmaffione requested review of this revision.Jun 15 2020, 8:12 PM
Harbormaster completed remote builds in B31723: Diff 73148.Jun 15 2020, 8:12 PM
vmaffione retitled this revision from ifconfig does not honor disabling vlanhwcsum to ifconfig does not honor disabling vlanhwtag.Jun 16 2020, 5:54 AM
vmaffione edited the summary of this revision. (Show Details)
vmaffione added a reviewer: gallatin.Jun 30 2020, 7:39 PM

Any opinions about this?

This revision was not accepted when it landed; it landed in state Needs Review.Aug 6 2020, 9:01 PM
Closed by commit rS363995: em(4): honor vlanhwtag offload (authored by vmaffione). · Explain Why
This revision was automatically updated to reflect the committed changes.
vmaffione added a commit: rS363995: em(4): honor vlanhwtag offload.
vmaffione added a commit: rS364878: MFC r363995.Aug 27 2020, 7:12 PM
vmaffione added a commit: rS364879: MFC r363995.Aug 27 2020, 7:15 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
e1000/
5 lines

Diff 73148

View Options

sys/dev/e1000/if_em.c

Loading...