Supply RB_COLOR macro
ClosedPublic
Actions

Authored by dougm on Jun 9 2020, 11:14 PM.

Tags

None

Referenced Files

	F170850318: D25204.id72908.diff
	Mon, Sep 7, 1:03 AM

	F170844077: D25204.id72906.diff
	Mon, Sep 7, 12:04 AM

	F170827990: D25204.id72903.diff
	Sun, Sep 6, 9:23 PM

	F170822652: D25204.id72904.diff
	Sun, Sep 6, 8:39 PM

	Unknown Object (File)
	Sun, Sep 6, 5:47 AM

	Unknown Object (File)
	Sun, Sep 6, 4:26 AM

	Unknown Object (File)
	Sun, Sep 6, 2:19 AM

	Unknown Object (File)
	Sat, Sep 5, 11:04 PM

Subscribers

Details

Reviewers

markj

Commits

rS361997: Restore an RB_COLOR macro, for the benefit of a bit of DIAGNOSTIC code

Summary

Lint kernels define DIAGNOSTIC and depend on RB_COLOR in subr_stats.c. Provide an RB_COLOR macro for them.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.Jun 9 2020, 11:14 PM

dougm created this revision.

Include the root-of-tree case.

Same change as before, from the right directory this time.

I'm also happy to just change the subr_stats.c code. Having RB_TREE and ARB_TREE bound tightly like this makes another RB_TREE change I'm considering impossible.

I think this is fine as an interim solution if it fixes the build. I don't see any problem with modifying the stats code as you see fit, though. It was added to FreeBSD only quite recently.

This revision is now accepted and ready to land.Jun 9 2020, 11:53 PM

Closed by commit rS361997: Restore an RB_COLOR macro, for the benefit of a bit of DIAGNOSTIC code (authored by dougm). · Explain WhyJun 10 2020, 2:50 AM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rS361997: Restore an RB_COLOR macro, for the benefit of a bit of DIAGNOSTIC code.

Herald added a subscriber: imp. · View Herald TranscriptJun 10 2020, 2:50 AM