Page MenuHomeFreeBSD

gptboot.efi: align secbuf to 4K
ClosedPublic

Authored by mhorne on Jun 3 2020, 12:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 10:25 AM
Unknown Object (File)
Sun, Dec 8, 10:25 AM
Unknown Object (File)
Sun, Dec 8, 10:25 AM
Unknown Object (File)
Fri, Dec 6, 1:51 PM
Unknown Object (File)
Mon, Dec 2, 12:58 AM
Unknown Object (File)
Mon, Dec 2, 12:57 AM
Unknown Object (File)
Nov 13 2024, 9:46 AM
Unknown Object (File)
Oct 30 2024, 12:16 AM
Subscribers

Details

Summary

The u-boot EFI implementation of the ReadBlocks and WriteBlocks methods
requires that the provided buffer meet the IO alignment requirements of
the underlying disk. Unlike loader.efi, gptboot.efi doesn't check this
requirement, and therefore fails to perform a successful read. Adjust
secbuf's alignment to 4K in hopes that we will always meet this
requirement.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

We boot off 512byte devices... good find...

This revision is now accepted and ready to land.Jun 3 2020, 3:01 AM
This revision was automatically updated to reflect the committed changes.