Page MenuHomeFreeBSD

netinet: make ifa_ifwithaddr() and ifa_ifwithaddr_check() fib-aware
Needs ReviewPublic

Authored by nc on May 24 2020, 11:26 PM.
Referenced Files
Unknown Object (File)
Thu, Oct 1, 6:12 AM
Unknown Object (File)
Thu, Sep 24, 3:23 AM
Unknown Object (File)
Mon, Sep 21, 1:08 PM
Unknown Object (File)
Sat, Sep 19, 8:50 AM
Unknown Object (File)
Fri, Sep 11, 3:26 AM
Unknown Object (File)
Thu, Sep 10, 12:14 PM
Unknown Object (File)
Thu, Sep 10, 8:23 AM
Unknown Object (File)
Mon, Sep 7, 9:14 PM

Details

Reviewers
melifaro
Summary

netinet: make ifa_ifwithaddr() and ifa_ifwithaddr_check() fib-aware

Submitted by: Neel Chauhan <neel AT neelc DOT org>

Test Plan
  1. Set net.fibs between 2-16 in /boot/loader.conf
  1. Add a route in say FIB 1 which points to a subnet (e.g. default router, or subnet behind subrouter)
  1. Do a ping/traceroute to a destination with an ICMP redirect, say a subrouter behind your router, but the subrouter's "external" interface is on the same subnet but different IP as your fib 1 router IP (which also has a route to the subrouter)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

nc requested review of this revision.May 24 2020, 11:26 PM

Can you please fill in the testing section?

nc added a reviewer: melifaro.

Sorry for the delay, I filled in the testing section.