Switch cxgbe interface lookup to use fibX_lookup() from older fibX_lookup_nh_ext().

[melifaro]

Summary

fibX_lookup_nh_ represents pre-epoch generation of fib api,
providing less guarantees over pointer validness and requiring
on-stack data copying.

NOTE: probably epoch coverage should be extended over entire c4iw_connect() to provide better guarantees over interface removal in-flight.

[melifaro]

Include tom changes as well.

[np]

I will try this and let you know how it went by June 10.

[melifaro]

In D24975#555169, @np wrote:

I will try this and let you know how it went by June 10.

That would be awesome!

[np]

Seems like t4_listen is missing an include.

• t4_listen.o ---

/root/ws/head/sys/dev/cxgbe/tom/t4_listen.c:1071:9: error: incomplete definition of type 'struct nhop_object'

if (nh->nh_ifp != ifp)
    ~~^

/root/ws/head/sys/net/route.h:53:9: note: forward declaration of 'struct nhop_object'

struct  nhop_object *ro_nh;
        ^

/root/ws/head/sys/dev/cxgbe/tom/t4_listen.c:1073:9: error: incomplete definition of type 'struct nhop_object'

if (nh->nh_flags & NHF_GATEWAY)
    ~~^

/root/ws/head/sys/net/route.h:53:9: note: forward declaration of 'struct nhop_object'

struct  nhop_object *ro_nh;

[np]

sys/dev/cxgbe/tom/t4_listen.c

1087 ↗

(On Diff #72166)

This should be gw4_sa or it won't compile:
t4_listen.o ---
/root/ws/head/sys/dev/cxgbe/tom/t4_listen.c:1088:54: error: no member named 'sin_addr' in 'struct sockaddr'

((struct sockaddr_in *)dst)->sin_addr = nh->gw_sa.sin_addr;
                                        ~~~~~~~~~ ^

1 error generated.

[np]

sys/dev/cxgbe/iw_cxgbe/cm.c

2640 ↗

(On Diff #72166)

cm.o ---
et is undefined.

/root/ws/head/sys/dev/cxgbe/iw_cxgbe/cm.c:2640:18: error: use of undeclared identifier 'et'

NET_EPOCH_ENTER(et);
                ^

/root/ws/head/sys/dev/cxgbe/iw_cxgbe/cm.c:2644:17: error: use of undeclared identifier 'et'

NET_EPOCH_EXIT(et);
               ^

[np]

This change works once the compilation issues are fixed.