Use fib[46]_lookup() in mtu calculations.
ClosedPublic
Actions

Authored by melifaro on May 23 2020, 1:09 PM.

Details

Reviewers

None

Group Reviewers

network
transport

Commits

rS361576: Use fib[46]_lookup() in mtu calculations.

Summary

fib[46]_lookup_nh_ represents pre-epoch generation of fib api,
providing less guarantees over pointer validness and requiring
on-stack data copying.

Conversion is straight-forwarded, as the only 2 differences are
requirement of running in network epoch and the need to handle
RTF_GATEWAY case in the caller code.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro created this revision.May 23 2020, 1:09 PM

Herald added a reviewer: transport. · View Herald TranscriptMay 23 2020, 1:09 PM

Herald added subscribers: bz, ae, imp. · View Herald Transcript

melifaro requested review of this revision.May 23 2020, 1:09 PM

Harbormaster completed remote builds in B31255: Diff 72163.May 23 2020, 1:09 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 28 2020, 8:00 AM

Closed by commit rS361576: Use fib[46]_lookup() in mtu calculations. (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rS361576: Use fib[46]_lookup() in mtu calculations..

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_subr.c

22 lines

netinet6/

icmp6.c

2 lines

Diff 72358

View Options

head/sys/netinet/tcp_subr.c