Enter epoch before sending ACK in BBR
ClosedPublic
Actions

Authored by tuexen on May 4 2020, 8:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 14, 8:59 AM

	Unknown Object (File)
	Tue, Oct 14, 8:59 AM

	Unknown Object (File)
	Tue, Oct 14, 8:58 AM

	Unknown Object (File)
	Mon, Oct 13, 7:05 PM

	Unknown Object (File)
	Tue, Sep 30, 3:52 AM

	Unknown Object (File)
	Sun, Sep 21, 9:07 PM

	Unknown Object (File)
	Sun, Sep 21, 10:29 AM

	Unknown Object (File)
	Sun, Sep 21, 4:54 AM

View All 79 Files

Subscribers

imp

melifaro

Details

Reviewers

rrs
rscheff

Group Reviewers

transport

Commits

rS360641: Enter the net epoch before calling the output routine in TCP BBR.

Summary

When the user sets the IPPROTO_TCP level socket option TCP_DELACK, an ACK is sent. Enter the epoch before calling the output routine.

This issues was found by running SYZKALLER.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.May 4 2020, 8:40 PM

Herald added a reviewer: transport. · View Herald TranscriptMay 4 2020, 8:40 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.May 4 2020, 8:40 PM

Harbormaster completed remote builds in B30900: Diff 71382.May 4 2020, 8:40 PM

rrs accepted this revision.May 4 2020, 9:55 PM

This revision is now accepted and ready to land.May 4 2020, 9:55 PM

Closed by commit rS360641: Enter the net epoch before calling the output routine in TCP BBR. (authored by tuexen). · Explain WhyMay 4 2020, 10:03 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rS360641: Enter the net epoch before calling the output routine in TCP BBR..

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_stacks/

bbr.c

3 lines

Diff 71389

View Options

head/sys/netinet/tcp_stacks/bbr.c

Enter epoch before sending ACK in BBRClosedPublicActions