Page MenuHomeFreeBSD
Differential D24323

casper: Export functions to C++
ClosedPublic
Actions

Authored by cem on Apr 7 2020, 1:50 AM.
Tags
None
Referenced Files
F152565122: D24323.id70303.diff
Wed, Apr 15, 5:36 PM
Unknown Object (File)
Mon, Apr 13, 3:18 AM
Unknown Object (File)
Sun, Apr 12, 7:17 PM
Unknown Object (File)
Tue, Apr 7, 12:18 AM
Unknown Object (File)
Mon, Apr 6, 9:04 PM
Unknown Object (File)
Mon, Apr 6, 9:58 AM
Unknown Object (File)
Sun, Apr 5, 8:07 AM
Unknown Object (File)
Sat, Apr 4, 12:18 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
oshogbo
vangyzen
Commits
rS359696: libcasper(3): Export functions to C++
Summary

Need to wrap C declarations in BEGIN/END DECLS to avoid C++ name-mangling the
declaration, which causes the linker to attempt to locate the wrong symbol
name.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cem created this revision.Apr 7 2020, 1:50 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 7 2020, 1:50 AM
Harbormaster completed remote builds in B30336: Diff 70288.Apr 7 2020, 1:50 AM
markj accepted this revision.Apr 7 2020, 3:33 PM
markj added inline comments.
lib/libcasper/services/cap_dns/cap_dns.h
39 ↗(On Diff #70288)

Why types.h in some places but cdefs.h in others?

This revision is now accepted and ready to land.Apr 7 2020, 3:33 PM
oshogbo accepted this revision.Apr 7 2020, 3:39 PM
cem added inline comments.Apr 7 2020, 4:36 PM
lib/libcasper/services/cap_dns/cap_dns.h
39 ↗(On Diff #70288)

Should just be cdefs, sorry. Editing these was a manual process with some missteps, I'll fix that.

cem updated this revision to Diff 70302.Apr 7 2020, 4:37 PM

sys/cdefs.h universally.

This revision now requires review to proceed.Apr 7 2020, 4:37 PM
Harbormaster completed remote builds in B30340: Diff 70302.Apr 7 2020, 4:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2020, 4:40 PM
Closed by commit rS359696: libcasper(3): Export functions to C++ (authored by cem). · Explain Why
This revision was automatically updated to reflect the committed changes.
cem marked an inline comment as done.
cem added a commit: rS359696: libcasper(3): Export functions to C++.

Revision Contents
Changeset List

PathSize
head/
lib/
libcasper/
services/
cap_dns/
5 lines
cap_fileargs/
6 lines
cap_grp/
7 lines
cap_pwd/
7 lines
cap_sysctl/
7 lines
cap_syslog/
7 lines

Diff 70303

View Options

head/lib/libcasper/services/cap_dns/cap_dns.h

Loading...
View Options

head/lib/libcasper/services/cap_fileargs/cap_fileargs.h

Loading...
View Options

head/lib/libcasper/services/cap_grp/cap_grp.h

Loading...
View Options

head/lib/libcasper/services/cap_pwd/cap_pwd.h

Loading...
View Options

head/lib/libcasper/services/cap_sysctl/cap_sysctl.h

Loading...
View Options

head/lib/libcasper/services/cap_syslog/cap_syslog.h

Loading...