Page MenuHomeFreeBSD
Differential D24323

casper: Export functions to C++
ClosedPublic
Actions

Authored by cem on Apr 7 2020, 1:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 7, 6:02 PM
Unknown Object (File)
Feb 18 2025, 2:05 AM
Unknown Object (File)
Feb 17 2025, 6:32 AM
Unknown Object (File)
Feb 17 2025, 1:49 AM
Unknown Object (File)
Feb 4 2025, 3:48 PM
Unknown Object (File)
Jan 17 2025, 1:43 AM
Unknown Object (File)
Nov 25 2024, 3:27 AM
Unknown Object (File)
Oct 6 2024, 9:10 PM
View All 59 Files
Subscribers
imp

Details

Reviewers
markj
emaste
oshogbo
vangyzen
Commits
rS359696: libcasper(3): Export functions to C++
Summary

Need to wrap C declarations in BEGIN/END DECLS to avoid C++ name-mangling the
declaration, which causes the linker to attempt to locate the wrong symbol
name.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cem created this revision.Apr 7 2020, 1:50 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 7 2020, 1:50 AM
Harbormaster completed remote builds in B30336: Diff 70288.Apr 7 2020, 1:50 AM
markj accepted this revision.Apr 7 2020, 3:33 PM
markj added inline comments.
lib/libcasper/services/cap_dns/cap_dns.h
39 ↗(On Diff #70288)

Why types.h in some places but cdefs.h in others?

This revision is now accepted and ready to land.Apr 7 2020, 3:33 PM
oshogbo accepted this revision.Apr 7 2020, 3:39 PM
cem added inline comments.Apr 7 2020, 4:36 PM
lib/libcasper/services/cap_dns/cap_dns.h
39 ↗(On Diff #70288)

Should just be cdefs, sorry. Editing these was a manual process with some missteps, I'll fix that.

cem updated this revision to Diff 70302.Apr 7 2020, 4:37 PM

sys/cdefs.h universally.

This revision now requires review to proceed.Apr 7 2020, 4:37 PM
Harbormaster completed remote builds in B30340: Diff 70302.Apr 7 2020, 4:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2020, 4:40 PM
Closed by commit rS359696: libcasper(3): Export functions to C++ (authored by cem). · Explain Why
This revision was automatically updated to reflect the committed changes.
cem marked an inline comment as done.
cem added a commit: rS359696: libcasper(3): Export functions to C++.

Revision Contents
Changeset List

PathSize
head/
lib/
libcasper/
services/
cap_dns/
5 lines
cap_fileargs/
6 lines
cap_grp/
7 lines
cap_pwd/
7 lines
cap_sysctl/
7 lines
cap_syslog/
7 lines

Diff 70303

View Options

head/lib/libcasper/services/cap_dns/cap_dns.h

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines <li>
<p>A list of FreeBSD branches that may be affected. <p>A list of FreeBSD branches that may be affected.
Expansions of scope require a new request to and approval Expansions of scope require a new request to and approval
from the FreeBSD Core Team.</p> from the FreeBSD Core Team.</p>
</li> </li>
</ul> </ul>
</li> </li>
<li> <li>
<p>We will allow existing GPLv2 licensed software to be
converted to GPLv3 or other similar license changes on a
case-by-case basis provided that the FreeBSD Core Team is
given appropriate technical justification.</p>
<p>Each piece of software that is being converted to a
different license must be submitted to the FreeBSD Core Team
for approval through this process as though it were a new
piece of software.</p>
<p>For Free Software Foundation maintained software except
GCC, GDB, and binutils, all patches posted after the date the
software switched to GPLv3 will be considered to be covered by
the GPLv3 and thus will be subject to this rule. For GCC, GDB
and binutils we accept the community practice of allowing
patches to be relicensed under GPLv2 at the patch author's
discretion. The author's permission must be documented in the
commit message for each patch that is committed.</p>
</li>
<li>
<p>Historically, the phrase 'All Rights Reserved.' was <p>Historically, the phrase 'All Rights Reserved.' was
included in all copyright notices. The BSD releases had it to included in all copyright notices. The BSD releases had it to
comply with the Buenos Aires Convention of 1910 in the comply with the Buenos Aires Convention of 1910 in the
Americas. With the ratification of the Berne Convention in Americas. With the ratification of the Berne Convention in
2000, it became obsolete. As such, the FreeBSD project 2000, it became obsolete. As such, the FreeBSD project
recommends that new code omit the phrase and encourages recommends that new code omit the phrase and encourages
existing copyright holders to remove it. In 2018, the project existing copyright holders to remove it. In 2018, the project
updated its templates to remove it.</p> updated its templates to remove it.</p>
▲ Show 20 Lines • Show All 135 Lines • Show Last 20 Lines
View Options

head/lib/libcasper/services/cap_fileargs/cap_fileargs.h

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines <li>
<p>A list of FreeBSD branches that may be affected. <p>A list of FreeBSD branches that may be affected.
Expansions of scope require a new request to and approval Expansions of scope require a new request to and approval
from the FreeBSD Core Team.</p> from the FreeBSD Core Team.</p>
</li> </li>
</ul> </ul>
</li> </li>
<li> <li>
<p>We will allow existing GPLv2 licensed software to be
converted to GPLv3 or other similar license changes on a
case-by-case basis provided that the FreeBSD Core Team is
given appropriate technical justification.</p>
<p>Each piece of software that is being converted to a
different license must be submitted to the FreeBSD Core Team
for approval through this process as though it were a new
piece of software.</p>
<p>For Free Software Foundation maintained software except
GCC, GDB, and binutils, all patches posted after the date the
software switched to GPLv3 will be considered to be covered by
the GPLv3 and thus will be subject to this rule. For GCC, GDB
and binutils we accept the community practice of allowing
patches to be relicensed under GPLv2 at the patch author's
discretion. The author's permission must be documented in the
commit message for each patch that is committed.</p>
</li>
<li>
<p>Historically, the phrase 'All Rights Reserved.' was <p>Historically, the phrase 'All Rights Reserved.' was
included in all copyright notices. The BSD releases had it to included in all copyright notices. The BSD releases had it to
comply with the Buenos Aires Convention of 1910 in the comply with the Buenos Aires Convention of 1910 in the
Americas. With the ratification of the Berne Convention in Americas. With the ratification of the Berne Convention in
2000, it became obsolete. As such, the FreeBSD project 2000, it became obsolete. As such, the FreeBSD project
recommends that new code omit the phrase and encourages recommends that new code omit the phrase and encourages
existing copyright holders to remove it. In 2018, the project existing copyright holders to remove it. In 2018, the project
updated its templates to remove it.</p> updated its templates to remove it.</p>
▲ Show 20 Lines • Show All 135 Lines • Show Last 20 Lines
View Options

head/lib/libcasper/services/cap_grp/cap_grp.h

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines <li>
<p>A list of FreeBSD branches that may be affected. <p>A list of FreeBSD branches that may be affected.
Expansions of scope require a new request to and approval Expansions of scope require a new request to and approval
from the FreeBSD Core Team.</p> from the FreeBSD Core Team.</p>
</li> </li>
</ul> </ul>
</li> </li>
<li> <li>
<p>We will allow existing GPLv2 licensed software to be
converted to GPLv3 or other similar license changes on a
case-by-case basis provided that the FreeBSD Core Team is
given appropriate technical justification.</p>
<p>Each piece of software that is being converted to a
different license must be submitted to the FreeBSD Core Team
for approval through this process as though it were a new
piece of software.</p>
<p>For Free Software Foundation maintained software except
GCC, GDB, and binutils, all patches posted after the date the
software switched to GPLv3 will be considered to be covered by
the GPLv3 and thus will be subject to this rule. For GCC, GDB
and binutils we accept the community practice of allowing
patches to be relicensed under GPLv2 at the patch author's
discretion. The author's permission must be documented in the
commit message for each patch that is committed.</p>
</li>
<li>
<p>Historically, the phrase 'All Rights Reserved.' was <p>Historically, the phrase 'All Rights Reserved.' was
included in all copyright notices. The BSD releases had it to included in all copyright notices. The BSD releases had it to
comply with the Buenos Aires Convention of 1910 in the comply with the Buenos Aires Convention of 1910 in the
Americas. With the ratification of the Berne Convention in Americas. With the ratification of the Berne Convention in
2000, it became obsolete. As such, the FreeBSD project 2000, it became obsolete. As such, the FreeBSD project
recommends that new code omit the phrase and encourages recommends that new code omit the phrase and encourages
existing copyright holders to remove it. In 2018, the project existing copyright holders to remove it. In 2018, the project
updated its templates to remove it.</p> updated its templates to remove it.</p>
▲ Show 20 Lines • Show All 135 Lines • Show Last 20 Lines
View Options

head/lib/libcasper/services/cap_pwd/cap_pwd.h

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines <li>
<p>A list of FreeBSD branches that may be affected. <p>A list of FreeBSD branches that may be affected.
Expansions of scope require a new request to and approval Expansions of scope require a new request to and approval
from the FreeBSD Core Team.</p> from the FreeBSD Core Team.</p>
</li> </li>
</ul> </ul>
</li> </li>
<li> <li>
<p>We will allow existing GPLv2 licensed software to be
converted to GPLv3 or other similar license changes on a
case-by-case basis provided that the FreeBSD Core Team is
given appropriate technical justification.</p>
<p>Each piece of software that is being converted to a
different license must be submitted to the FreeBSD Core Team
for approval through this process as though it were a new
piece of software.</p>
<p>For Free Software Foundation maintained software except
GCC, GDB, and binutils, all patches posted after the date the
software switched to GPLv3 will be considered to be covered by
the GPLv3 and thus will be subject to this rule. For GCC, GDB
and binutils we accept the community practice of allowing
patches to be relicensed under GPLv2 at the patch author's
discretion. The author's permission must be documented in the
commit message for each patch that is committed.</p>
</li>
<li>
<p>Historically, the phrase 'All Rights Reserved.' was <p>Historically, the phrase 'All Rights Reserved.' was
included in all copyright notices. The BSD releases had it to included in all copyright notices. The BSD releases had it to
comply with the Buenos Aires Convention of 1910 in the comply with the Buenos Aires Convention of 1910 in the
Americas. With the ratification of the Berne Convention in Americas. With the ratification of the Berne Convention in
2000, it became obsolete. As such, the FreeBSD project 2000, it became obsolete. As such, the FreeBSD project
recommends that new code omit the phrase and encourages recommends that new code omit the phrase and encourages
existing copyright holders to remove it. In 2018, the project existing copyright holders to remove it. In 2018, the project
updated its templates to remove it.</p> updated its templates to remove it.</p>
▲ Show 20 Lines • Show All 135 Lines • Show Last 20 Lines
View Options

head/lib/libcasper/services/cap_sysctl/cap_sysctl.h

Loading...
View Options

head/lib/libcasper/services/cap_syslog/cap_syslog.h

Loading...