Page MenuHomeFreeBSD

casper: Export functions to C++
ClosedPublic

Authored by cem on Apr 7 2020, 1:50 AM.

Details

Summary

Need to wrap C declarations in BEGIN/END DECLS to avoid C++ name-mangling the
declaration, which causes the linker to attempt to locate the wrong symbol
name.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj added inline comments.
lib/libcasper/services/cap_dns/cap_dns.h
39 ↗(On Diff #70288)

Why types.h in some places but cdefs.h in others?

This revision is now accepted and ready to land.Apr 7 2020, 3:33 PM
lib/libcasper/services/cap_dns/cap_dns.h
39 ↗(On Diff #70288)

Should just be cdefs, sorry. Editing these was a manual process with some missteps, I'll fix that.

sys/cdefs.h universally.

This revision now requires review to proceed.Apr 7 2020, 4:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2020, 4:40 PM
This revision was automatically updated to reflect the committed changes.
cem marked an inline comment as done.