riscv: Make sure local hart's icache is synced in pmap_sync_icache
ClosedPublic
Actions

Authored by jrtc27 on Apr 6 2020, 8:59 PM.

Tags

None

Referenced Files

	F153387187: D24317.diff
	Mon, Apr 20, 9:00 PM

	Unknown Object (File)
	Wed, Apr 15, 9:19 AM

	Unknown Object (File)
	Fri, Apr 10, 1:00 AM

	Unknown Object (File)
	Thu, Apr 9, 10:12 AM

	Unknown Object (File)
	Thu, Apr 9, 3:56 AM

	Unknown Object (File)
	Mon, Apr 6, 3:13 PM

	Unknown Object (File)
	Sat, Apr 4, 5:48 PM

	Unknown Object (File)
	Sat, Mar 28, 4:51 AM

View All 72 Files

Subscribers

imp

Details

Reviewers

jhb
markj
br

Commits

rS359672: riscv: Make sure local hart's icache is synced in pmap_sync_icache

Summary

The only way to flush the local hart's icache is with a FENCE.I (or an
equivalent SBI call); a normal FENCE is insufficient and, for the
single-hart case, unnecessary.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Apr 6 2020, 8:59 PM

Harbormaster completed remote builds in B30325: Diff 70272.Apr 6 2020, 8:59 PM

I broke this in rS339367 when I switched to using sbi_remove_fence_i as I had cleared the current CPU from the mask before passing that mask to SBI.

This revision is now accepted and ready to land.Apr 6 2020, 9:42 PM

markj accepted this revision.Apr 6 2020, 9:48 PM

Closed by commit rS359672: riscv: Make sure local hart's icache is synced in pmap_sync_icache (authored by jrtc27). · Explain WhyApr 6 2020, 10:31 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rS359672: riscv: Make sure local hart's icache is synced in pmap_sync_icache.

Herald added a subscriber: imp. · View Herald TranscriptApr 6 2020, 10:31 PM