mlx5en: increment enobuf counter when tx schedule is out of space
ClosedPublic
Actions

Authored by • hselasky on Apr 3 2020, 8:51 PM.

Details

Reviewers

kib
rrs
gallatin
• hselasky

Commits

rS359855: MFC r359653:
rS359853: MFC r359653:
rS359851: MFC r359653:
rS359653: Count number of times transmit ring is out of buffers in mlx5en(4).

Summary

Fix a bug where mlx5en silently drops packets in the output path.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gallatin created this revision.Apr 3 2020, 8:51 PM

Herald added subscribers: ae, imp. · View Herald TranscriptApr 3 2020, 8:51 PM

Harbormaster completed remote builds in B30260: Diff 70159.Apr 3 2020, 8:51 PM

• hselasky added inline comments.Apr 4 2020, 1:08 AM

sys/dev/mlx5/mlx5_en/mlx5_en_tx.c
801 ↗	(On Diff #70159)	Please identify the return cases which are not "tx_drop:" in mlx5e_sq_xmit() and increment there. Else you increment twice dropped!

kib added inline comments.Apr 4 2020, 1:14 AM

sys/dev/mlx5/mlx5_en/mlx5_en_tx.c
398 ↗	(On Diff #70159)	I am not sure if this a right thing to do there. But also I am not sure how this case could happen at all.

• hselasky commandeered this revision.Apr 6 2020, 9:34 AM

• hselasky updated this revision to Diff 70244.

• hselasky edited reviewers, added: gallatin; removed: • hselasky.

• hselasky retitled this revision from mlx5en: increment tx drop counter when dropping packets to mlx5en: increment enobuf counter when tx schedule is out of space.

• hselasky edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B30308: Diff 70244.Apr 6 2020, 9:36 AM

• hselasky accepted this revision.Apr 6 2020, 9:36 AM

This revision is now accepted and ready to land.Apr 6 2020, 9:36 AM

Closed by commit rS359653: Count number of times transmit ring is out of buffers in mlx5en(4). (authored by • hselasky). · Explain WhyApr 6 2020, 9:41 AM

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rS359653: Count number of times transmit ring is out of buffers in mlx5en(4)..

• hselasky added a commit: rS359851: MFC r359653:.Apr 13 2020, 8:56 AM

• hselasky added a commit: rS359853: MFC r359653:.Apr 13 2020, 8:58 AM

• hselasky added a commit: rS359855: MFC r359653:.Apr 13 2020, 9:02 AM