Makes col(1) respect posix again for escape sequences as decribed in its manpage
The bug was introduced in CSRG in 1991
This also reverts r280911
Details
Details
- Reviewers
eadler jhb - Commits
- rS282305: col: fixing 25 year old bug
using heirloom doctools's tbl and nroff rendering share/doc/usd/10.exref/summary/ex.summary
tbl -Tlp ex.summary | nroff -Tlp -ms | /usr/bin/col -x | less
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
usr.bin/col/col.c | ||
---|---|---|
380–381 ↗ | (On Diff #5141) | having these as named constants would be nice. |
Comment Actions
It was broken in 1990 instead of 1991. :)
usr.bin/col/col.c | ||
---|---|---|
380 ↗ | (On Diff #5141) | I wonder if this shouldn't be using the constants here (ESC, FHLF, etc.). I think it might be clearer if it did? |
usr.bin/col/col.c | ||
---|---|---|
380–381 ↗ | (On Diff #5141) | None of the PUTC uses the name constant so one would have to go through the whole code to change it everywhere while this is a good idea it should be done in a separate commit |
head/usr.bin/col/col.c | ||
---|---|---|
381 | Any reason not to use FHLF instead of the bare '9' here? |
Comment Actions
I wanted to separate in 2 commits, now it uses the defines for all PUTC where accurate