Use the real value of MK_TESTS_SUPPORT in _libraries.
ClosedPublic
Actions

Authored by brooks on Mar 27 2020, 8:31 PM.

Details

Reviewers

imp
emaste
bdrewery

Commits

rS359382: Use the real value of MK_TESTS_SUPPORT in _libraries.

Summary

This fixes WITHOUT_TESTS + WITH_TESTS_SUPPORT builds.

r273449 added WITH_TESTS_SUPPORT and set MK_TESTS_SUPPORT to MK_TESTS in
this stage due to a claimed race betwen lib/atf and libexec/atf. It's
not apparent how this could ever happen and not fully populating
WORLDTMP in _libraries seems wrong.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Mar 27 2020, 8:31 PM

Harbormaster completed remote builds in B30139: Diff 69933.Mar 27 2020, 8:31 PM

Seems reasonable to me

This revision is now accepted and ready to land.Mar 27 2020, 8:49 PM

This definitely doesn't work. https://cirrus-ci.com/task/5639234392424448 (Breaks normal builds).

I believe what's happening is that MK_TESTS=no is causing MK_TESTS_SUPPORT to be implied in the sub make. I'm now testing a change where we pass the currently value of MK_TESTS_SUPPORT on through.