Page MenuHomeFreeBSD

Remove liby and liblBoth libs are ancient libs that aren't (and shouldn't be) used anymore
AcceptedPublic

Authored by manu on Tue, Mar 24, 7:35 AM.

Details

Reviewers
bapt
emaste
Group Reviewers
pkgbase
Test Plan

Base builds fine.
Exp-Run requested in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245027

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 30115
Build 27922: arc lint + arc unit

Event Timeline

manu created this revision.Tue, Mar 24, 7:35 AM
manu retitled this revision from Remove liby and libl Both libs are ancient libs that aren't (and shouldn't be) used anymore to Remove liby and liblBoth libs are ancient libs that aren't (and shouldn't be) used anymore.Tue, Mar 24, 7:39 AM
manu edited the test plan for this revision. (Show Details)
manu set the repository for this revision to rS FreeBSD src repository.
bapt added a comment.Tue, Mar 24, 1:48 PM

The Makefile.inc1 and Makefile.libcompat can probably be committed right now.

Makefile.inc1
2076 ↗(On Diff #69818)

This part can probably be committed straight away

2220 ↗(On Diff #69818)

same

2840 ↗(On Diff #69818)

same

Makefile.libcompat
41 ↗(On Diff #69818)

and again

I wasn't sure about committing in 2 parts but @imp points out that's beneficial for MFC - so yeah, let's commit the disuse of these libs first.

manu updated this revision to Diff 69886.Thu, Mar 26, 8:34 AM

Update after r359324

emaste accepted this revision.Fri, Mar 27, 7:03 PM
emaste added inline comments.
share/mk/bsd.suffixes.mk
95–101

These two are MFCable I think?

This revision is now accepted and ready to land.Fri, Mar 27, 7:03 PM
manu added inline comments.Sat, Apr 4, 6:34 PM
share/mk/bsd.suffixes.mk
95–101

TBH I didn't planned to mfc anything on this review.
I guess those too could be mfc but I haven't tested anything on 12.

emaste added inline comments.Sat, Apr 4, 7:55 PM
share/mk/bsd.suffixes.mk
95–101

OK - I would commit them separately anyhow so that they could be MFC'd if someone is so inclined, even if you don't tag them as MFC or intend to do so.