Remove liby and liblBoth libs are ancient libs that aren't (and shouldn't be) used anymore
AcceptedPublic
Actions

Authored by manu on Mar 24 2020, 7:35 AM.

Details

Reviewers

bapt
emaste

Group Reviewers

pkgbase

Test Plan

Base builds fine.
Exp-Run requested in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245027

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30073
Build 27884: arc lint + arc unit

Event Timeline

manu created this revision.Mar 24 2020, 7:35 AM

Herald added subscribers: emaste, bdrewery. · View Herald TranscriptMar 24 2020, 7:35 AM

Harbormaster completed remote builds in B30073: Diff 69818.Mar 24 2020, 7:35 AM

manu retitled this revision from Remove liby and libl Both libs are ancient libs that aren't (and shouldn't be) used anymore to Remove liby and liblBoth libs are ancient libs that aren't (and shouldn't be) used anymore.Mar 24 2020, 7:39 AM

manu edited the test plan for this revision. (Show Details)

manu set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptMar 24 2020, 7:39 AM

The Makefile.inc1 and Makefile.libcompat can probably be committed right now.

Makefile.inc1
2076	This part can probably be committed straight away
2220	same
2840	same
Makefile.libcompat
41	and again

I wasn't sure about committing in 2 parts but @imp points out that's beneficial for MFC - so yeah, let's commit the disuse of these libs first.

manu mentioned this in rS359324: Stop building libl and liby.Mar 26 2020, 8:23 AM

Update after r359324

Harbormaster completed remote builds in B30115: Diff 69886.Mar 26 2020, 8:34 AM

emaste accepted this revision.Mar 27 2020, 7:03 PM

emaste added inline comments.

share/mk/bsd.suffixes.mk
95–101	These two are MFCable I think?

This revision is now accepted and ready to land.Mar 27 2020, 7:03 PM

manu added inline comments.Apr 4 2020, 6:34 PM

share/mk/bsd.suffixes.mk
95–101	TBH I didn't planned to mfc anything on this review. I guess those too could be mfc but I haven't tested anything on 12.

emaste added inline comments.Apr 4 2020, 7:55 PM

share/mk/bsd.suffixes.mk
95–101	OK - I would commit them separately anyhow so that they could be MFC'd if someone is so inclined, even if you don't tag them as MFC or intend to do so.