Else when WITHOUT_SENDMAIL is set with pkgbase we create a sendmail package containing nothing but two directories.
Details
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
We might need to look at a more holistic approach to this, e.g. adding an mtree option to include or exclude entries based on tags, or perhaps preprocessing the mtree files before stageworld. However, we already had BSD.sendmail.dist split out (although rS348981 re-added clientmqueue to BSD.var.dist, duplicating the entry in BSD.sendmail.dist) so it seemed sensible to use it for now.
BSD.var.dist still has at, dma, and unbound entries.
etc/mtree/BSD.sendmail.dist | ||
---|---|---|
15 | accidentally deleted a space on this line, will revert that before commit. |
It is fine to commit as is. One thing to consider would be simplifying:
/set gname=daemon mqueue tags=package=sendmail
to
mqueue gname=daemon tags=package=sendmail
(note that the mqueue line above should be indented but the comment block doesn't allow leading spaces)
Thanks, sorry I didn't see your comment before committing. I agree this is preferable and committed in rS359216 - although I don't think it matters too much for this specific instance there are are couple more cases in BSD.var.dist that we'll have to address and it's good to have this as a clean example.