Page MenuHomeFreeBSD

pci_early_quirk: Sync with drm-v5.0 (+extras)
Needs ReviewPublic

Authored by manu on Sun, Mar 22, 6:09 AM.

Details

Reviewers
kib
johalun
gnn
Summary

This adds all the current gen9 pci ids that were missing :

  • Some new coffee lake, kaby lake and whiskey lake ids
  • Comet lake ids (which is also gen9 but not yet supported by drm-devel-kmod)
Test Plan

Only build tested, I need @gnn to test on his laptop.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

manu created this revision.Sun, Mar 22, 6:09 AM
imp added a comment.Sun, Mar 22, 6:19 AM

Looks good to me, but I didn't verify the ids

manu added a comment.Sun, Mar 22, 6:39 AM
In D24143#530986, @imp wrote:

Looks good to me, but I didn't verify the ids

IDS were taken from https://github.com/evadot/kms-drm/blob/drm-v5.0-comet-lake/include/drm/i915_pciids.h (which this file originated from).

kib added a comment.Sun, Mar 22, 11:31 AM

Ok, but this pci_early_stuff shall be removed from the kernel. It was added with the promise that eventually code will be finished (by outguessing broken BIOSes and reserving the phys memory before VM takes hold on it). This never happen and right now it is just space taken in the kernel text.

It would live a more happy life in the driver instead.

manu added a comment.Mon, Mar 23, 1:29 AM
In D24143#531016, @kib wrote:

Ok, but this pci_early_stuff shall be removed from the kernel. It was added with the promise that eventually code will be finished (by outguessing broken BIOSes and reserving the phys memory before VM takes hold on it). This never happen and right now it is just space taken in the kernel text.
It would live a more happy life in the driver instead.

Ok, I could have a look at this later.
This doesn't seems to help @gnn anyway so no need for this to be commited now.