Page MenuHomeFreeBSD

Resurrect biology/linux-foldingathome
ClosedPublic

Authored by 0mp on Thu, Mar 19, 10:59 PM.

Details

Reviewers
netchild
Summary
Folding@home is a distributed computing project -- people from
throughout the world download and run software to band together to
make one of the largest supercomputers in the world. Every computer
takes the project closer to its goals. Folding@home uses novel
computational methods coupled to distributed computing, to simulate
problems millions of times more challenging than previously achieved.

WWW: https://foldingathome.org/
Test Plan
  • passes poudriere testport on 12.1 amd64
  • works fine on fairly recenty 13.0-CURRENT amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30038
Build 27849: arc lint + arc unit

Event Timeline

0mp created this revision.Thu, Mar 19, 10:59 PM
0mp updated this revision to Diff 69697.Thu, Mar 19, 11:00 PM
  • Add $FreeBSD$ to the service file
0mp updated this revision to Diff 69699.Thu, Mar 19, 11:03 PM
  • Add pkg-message to SUB_FILES
  • Improve pkg-descr
0mp updated this revision to Diff 69700.Thu, Mar 19, 11:27 PM
  • Move the port to the biology category (more specific than science)

I still have to test the patch properly, but here is some initial feedback:

  • the port builds successfully on 13.0-CURRENT r358923 (but I have not tested it yet, due to the fact that I run a custom kernel and similar issues);
  • etc/fahclient/config.xml file is with CRLF line terminators;
  • it would be nice to have an option to join the FreeBSD team (according to https://www.leidinger.net/blog/category/freebsd/linuxolator/ its number is 11743).

I will give more feedback after I test better the port.

pi added a subscriber: pi.Fri, Mar 20, 3:37 AM

testbuilds@work

pi added a comment.Fri, Mar 20, 3:53 AM

testbuilds are fine

netchild requested changes to this revision.Fri, Mar 20, 6:49 AM

Only reviewing the diff, I haven't tried on a real machine.

UID: calling it a desktop client when there is only the background process without a GUI is may a little bit too much.

Have you tried "service fahclient {status|stop}"? The rc script I have done on my own (a little bit different than yours) fails to do the right thing.

This revision now requires changes to proceed.Fri, Mar 20, 6:49 AM

FYI: in the past we had a folding@home client in the ports collection. It was named biology/linux-foldingathome. I'm not sure if this one should be done as a repo-copy from the old one or not...

I also suggest to add a little text about the need for exec=on for /var/db/fahclient if /var/db is on ZFS and has exec=off.

biology/fahclient/files/pkg-message.in
8 ↗(On Diff #69700)

/var/db normally doesn't need to have execute permissions. Maybe mention that if /var/db is on a ZFS dataset with exec=off, that /var/db/fahclient needs to have exec=on.

0mp updated this revision to Diff 69717.Fri, Mar 20, 1:10 PM
  • Resurect biology/linux-foldingathome
  • Use dos2unix on the config file
netchild requested changes to this revision.Fri, Mar 20, 2:03 PM

Please see my inline-comment for pkg-message.in, I think the text of the complete comment should be included. Please also remove the word "Desktop" from the UID file.

biology/linux-foldingathome/files/pkg-message.in
9
  • If you use ZFS, make sure that %%FAHCLIENT_HOME%% is configured as exec=on.

Optional:

  • Modify the team information in %%FAHCLIENT_CONFIG_XML%% if you want to join a team. If you want to join the FreeBSD team, the TeamID is 11743.
This revision now requires changes to proceed.Fri, Mar 20, 2:03 PM
0mp planned changes to this revision.Fri, Mar 20, 7:52 PM
0mp updated this revision to Diff 69747.Sat, Mar 21, 8:02 PM
  • Change user description in UIDs
  • List LICENSE_PERMS explicitly
  • Do not install desktop files: the web viewer is broken at the moment and causes an flood of errors in the logs of the service
  • Add LEGAL_TEXT
  • Set ETCDIR and DOCSDIR properly
  • Improve the service file (I confirm that all commands like status, start, stop, poll, and a custom one called "log" work)
  • Rewrite pkg-message
0mp marked an inline comment as done.Sat, Mar 21, 8:04 PM
0mp added inline comments.
biology/linux-foldingathome/files/pkg-message.in
9

Done!

Please, let me know if the wording is fine. I might have over complicated it a little bit...

netchild accepted this revision.Sat, Mar 21, 10:44 PM

Looks ok to me. Anything which comes up as an improvement is IMO minor and can be fixed as a follow-up commit.

This revision is now accepted and ready to land.Sat, Mar 21, 10:44 PM
0mp marked an inline comment as done.Sat, Mar 21, 11:10 PM

Thanks, everyone!

Hmmm... didn't you forgot to mention to change the user in the new pkg-message? Not sure if it is mandatory, and you point out to read-up about how to configure, but as you mention the FreeBSD team I would also mention to change the user. But as already told, I don't see a big showstopper, that's a detail which can be improved as time permits.

0mp closed this revision.Sun, Mar 22, 2:49 PM

Hmmm... didn't you forgot to mention to change the user in the new pkg-message? Not sure if it is mandatory, and you point out to read-up about how to configure, but as you mention the FreeBSD team I would also mention to change the user. But as already told, I don't see a big showstopper, that's a detail which can be improved as time permits.

I assumed that it should be covered by the official documentation of FAH.

Also, this is not strictly necessary to run FAH: anonymous user is just fine.

I am also super new to FAH so I don't know the community that much. So, if you think that pkg-message should mention that the user should consider setting their username in the config file then I'll add it :)

Also, this revision should have been closed autoamtically. It was already committed in r528886.

0mp added a comment.Sun, Mar 22, 4:55 PM

@netchild, nevermind, I juts updated the pkg-message :)

0mp retitled this revision from New port: science/fahclient to Resurrect biology/linux-foldingathome.Mon, Mar 23, 3:47 PM
0mp edited the summary of this revision. (Show Details)