Page MenuHomeFreeBSD

lang/go: relax module consistency checks if vendor/modules.txt is missing

Authored by dmgk on Thu, Mar 19, 1:48 PM.


Starting from go1.14, go verifes that vendor/modules.txt matches the requirements
and replacements listed in the main module go.mod file, and it is a hard failure if
vendor/modules.txt is missing.

Relax module consistency checks and switch back to pre go1.14 behaviour if
vendor/modules.txt is missing regardless of go version requirement in go.mod.

Bugzilla PR:
Upstream PR:
Test Plan

poudriere testport: OK

Diff Detail

rP FreeBSD ports repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dmgk created this revision.Thu, Mar 19, 1:48 PM
dmgk added a comment.Thu, Mar 19, 5:52 PM

It doesn't look like is going to be accepted by the upstream, any objections to keeping this as a local lang/go patch?

yuri accepted this revision.Thu, Mar 19, 5:58 PM
This revision is now accepted and ready to land.Thu, Mar 19, 5:58 PM
mikael accepted this revision.Thu, Mar 19, 6:33 PM
dmgk updated this revision to Diff 69691.Thu, Mar 19, 8:35 PM

Enable relaxed checks only when GO_NO_VENDOR_CHECKS=1 is set in the environment
(by - this should limit custom behaviour to port builds.

This revision now requires review to proceed.Thu, Mar 19, 8:35 PM
dmgk added a reviewer: swills.Thu, Mar 19, 8:36 PM
yuri accepted this revision.Thu, Mar 19, 9:26 PM
mikael accepted this revision.Fri, Mar 20, 12:31 PM
swills accepted this revision.Fri, Mar 27, 5:28 PM

With the environment variable check, I'm OK with it. Approved.

This revision is now accepted and ready to land.Fri, Mar 27, 5:28 PM
adamw added a subscriber: adamw.Mon, Mar 30, 4:27 PM

Just, checking in, where are we at with this? I have some port updates blocking on this.

yuri added a comment.Mon, Mar 30, 4:50 PM

It is waiting for a maintainer timeout.