Page MenuHomeFreeBSD

lang/go: relax module consistency checks if vendor/modules.txt is missing

Authored by dmgk on Mar 19 2020, 1:48 PM.


Starting from go1.14, go verifes that vendor/modules.txt matches the requirements
and replacements listed in the main module go.mod file, and it is a hard failure if
vendor/modules.txt is missing.

Relax module consistency checks and switch back to pre go1.14 behaviour if
vendor/modules.txt is missing regardless of go version requirement in go.mod.

Bugzilla PR:
Upstream PR:
Test Plan

poudriere testport: OK

Diff Detail

rP FreeBSD ports repository
Lint Not Applicable
Tests Not Applicable

Event Timeline

It doesn't look like is going to be accepted by the upstream, any objections to keeping this as a local lang/go patch?

This revision is now accepted and ready to land.Mar 19 2020, 5:58 PM

Enable relaxed checks only when GO_NO_VENDOR_CHECKS=1 is set in the environment
(by - this should limit custom behaviour to port builds.

This revision now requires review to proceed.Mar 19 2020, 8:35 PM

With the environment variable check, I'm OK with it. Approved.

This revision is now accepted and ready to land.Mar 27 2020, 5:28 PM

Just, checking in, where are we at with this? I have some port updates blocking on this.

It is waiting for a maintainer timeout.