Page MenuHomeFreeBSD
Differential D24004

SiFive/SPI: Silence build warning
ClosedPublic
Actions

Authored by nick on Mar 9 2020, 3:35 AM.
Tags
None
Referenced Files
F110438483: D24004.diff
Tue, Feb 18, 11:48 AM
Unknown Object (File)
Dec 22 2024, 10:16 AM
Unknown Object (File)
Dec 19 2024, 11:53 PM
Unknown Object (File)
Dec 10 2024, 7:03 AM
Unknown Object (File)
Nov 26 2024, 2:55 PM
Unknown Object (File)
Nov 26 2024, 2:55 PM
Unknown Object (File)
Nov 26 2024, 2:55 PM
Unknown Object (File)
Nov 20 2024, 9:04 AM
View All 46 Files
Subscribers
imp

Details

Reviewers
philip
kp
Commits
rS358801: fuspi: silence build warning, plug resource leak
Summary

This silences an "unused label" warning as well as fixes the attach fail
path that wasn't releasing resources.

Sponsored by: Axiado

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

nick created this revision.Mar 9 2020, 3:35 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 9 2020, 3:35 AM
philip accepted this revision.Mar 9 2020, 3:38 AM

Whoops.

Pointy hat to: philip :)

This revision is now accepted and ready to land.Mar 9 2020, 3:38 AM
Closed by commit rS358801: fuspi: silence build warning, plug resource leak (authored by philip). · Explain WhyMar 9 2020, 4:09 AM
This revision was automatically updated to reflect the committed changes.
philip added a commit: rS358801: fuspi: silence build warning, plug resource leak.

Revision Contents
Changeset List

PathSize
sys/
riscv/
sifive/
4 lines

Diff 69318

View Options

sys/riscv/sifive/fu540_spi.c

Loading...