New port net-p2p/mt-recorder: Rust based hashing program for the Bitmark Property System

[hsw_bitmark.com]

Summary

This is a Rust based hashing program for the Bitmark Property System
(net-p2p/bitmark).

It has two flavors the default which compiles with simd for modern
CPUs and mt-recorder@nosimd for older CPUs without the AVX feature

Also update UIDs and GIDs for mt-recorder user/group

Test Plan

poudriere (12.1-RELEASE amd64)

poudriere testport -j 12_1-amd64 net-p2p/mt-recorder
poudriere testport -j 12_1-amd64 net-p2p/mt-recorder@nosimd

[hsw_bitmark.com]

upload port files

[tobik]

net-p2p/mt-recorder/Makefile

14–15

Wrong order. See https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-order.html

Also please do not lock it to llvm80 and use ${LLVM_DEFAULT} here.

17

This should probably be an option not a flavor. When compiled with SIMD support the argonautica crate passes -march=native to the build [1], which means the package would be specific to the package builder hardware, i.e., the package would be broken on a large number of systems [2]. It is a waste of resources to build such packages.

[1] https://github.com/bcmyers/argonautica/blob/v0.2.0/argonautica-rs/build.rs#L67
[2] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-arch.html

22

USES=pkgconfig is already implied by CARGO_CRATES=pkgconfig. Please remove it.

155

Nop with USES=cargo ports. Please remove it.

If the binary needs to be stripped put a ${STRIP_CMD} in post-install.

163–168

There is no reason to use += anywhere in this port.

179

No need for the quotes.

[hsw_bitmark.com]

update to address the problems in review by @tobik

[mikael]

net-p2p/mt-recorder/Makefile

20

simd exists on arm*, ppc*. Is it limited to amd64?

[hsw_bitmark.com]

My present understanding is that SIMD exists on certain CPUs and that the way the Rust compiler works in that it does a native build
if SIMD feature is enabled which would mean that the build machine would have to support SIMD. Originally I had it as a flavour so
both kinds would have been built. I was recommended to convert to an option defaulted off so that build machines without SIMD
would not fail the SIMD version