Page MenuHomeFreeBSD

New port net-p2p/mt-recorder (v0.5.3)
Needs ReviewPublic

Authored by hsw_bitmark.com on Mar 3 2020, 7:06 AM.

Details

Reviewers
araujo
Summary

This is a Rust based hashing program for the Bitmark Property System
(net-p2p/bitmark).

It has two flavors the default which compiles with simd for modern
CPUs and mt-recorder@nosimd for older CPUs without the AVX feature

Also update UIDs and GIDs for mt-recorder user/group

Test Plan

poudriere (12.1-RELEASE amd64)

poudriere testport -j 12_1-amd64 net-p2p/mt-recorder
poudriere testport -j 12_1-amd64 net-p2p/mt-recorder@nosimd

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29850
Build 27674: arc lint + arc unit

Event Timeline

hsw_bitmark.com created this revision.Mar 3 2020, 7:06 AM

upload port files

tobik added a subscriber: tobik.Mar 8 2020, 4:59 PM
tobik added inline comments.
net-p2p/mt-recorder/Makefile
15–16

Wrong order. See https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-order.html

Also please do not lock it to llvm80 and use ${LLVM_DEFAULT} here.

18

This should probably be an option not a flavor. When compiled with SIMD support the argonautica crate passes -march=native to the build [1], which means the package would be specific to the package builder hardware, i.e., the package would be broken on a large number of systems [2]. It is a waste of resources to build such packages.

[1] https://github.com/bcmyers/argonautica/blob/v0.2.0/argonautica-rs/build.rs#L67
[2] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-arch.html

23

USES=pkgconfig is already implied by CARGO_CRATES=pkgconfig. Please remove it.

156

Nop with USES=cargo ports. Please remove it.

If the binary needs to be stripped put a ${STRIP_CMD} in post-install.

164–169

There is no reason to use += anywhere in this port.

180

No need for the quotes.

update to address the problems in review by @tobik