[devel/gdb] Update to GDB 9.1.

[jhb]

Summary

GDB 9 rejects attempts to build in the source tree, so this uses
CONFIGURE_OUTSOURCE.

Some patch files were renamed to track moving of files in upstream.

Test Plan

• bulk -t passes on amd64
• kgdb works in simple testing on amd64
• I have only tested that when guile is enabled 'make patch' doesn't fail, but have not otherwise tested the GUILE option

[jhb]

devel/gdb/Makefile

21

The build wanted makeinfo to build the info pages. Not sure why it didn't want that previously?

50

Sadly, I actually missed several files here (which is why there are commmit-* files deleted that aren't listed here), so TLS support for, e.g. RISC-V wasn't actually enabled. All the TLS bits I had committed post 8.3 are in GDB 9 though thankfully.

121

The build of the info files uses some files from the readline/ subdirectory as dependencies even though they aren't used for the actual build of the info files. There's an XXX comment about this in the gdb/doc/Makefile.in file.

133

The INSTALL_WRKSRC changes are all due to the use of CONFIGURE_OUTSOURCE

[pizzamig]

Unfortunately, on i386 the build fails. In kgdb/i386fbsd-kern.c there is still a TRY and CATCH in capitol letters

[jhb]

• Fix i386 build.
• Use lookup_struct_elt*() in kgdb.

[jhb]

In D23932#526419, @pizzamig wrote:

Unfortunately, on i386 the build fails. In kgdb/i386fbsd-kern.c there is still a TRY and CATCH in capitol letters

Oops, thanks for catching that. Should be fixed now.

[pizzamig]

It looks good to me! Feel free to commit!