Swap words order instead of bits order on BIG ENDIAN

[fernando.valle_eldorado.org.br]

Summary

The for loop on big endian was inverting all the bits instead of just the words

Test Plan

kyua test -k /usr/tests/lib/msun/Kyuafile nan_test

[pfg]

Hmm... if the tests pass I guess it is good, but does the comment need updating as well?
The else case in the old code was going backwards but this one doesn't.

[pfg]

Approved BTW, the code obviously doesn't change anything for LE.

[pfg]

The code is rather tricky, it would be convenient to checksum the object code on Little Endian to make sure nothing changes.

lib/msun/src/s_nan.c

75

Actually, this doesn't look like correct style: we need spaces around/within that -1- and you it seems like the line is too long.

[renato.riolino_eldorado.org.br]

Adjust code style

[pfg]

LGTM

lib/msun/src/s_nan.c

75

Minor knit, and strictly optional:
num_words - 1 - (bitpos / 32) is more readable
num_words - (bitpos / 32) - 1

[pfg]

lib/msun/src/s_nan.c

75

And actually the parenthesis is unnecessary, as division takes precedence over subtraction.

[fernando.valle_eldorado.org.br]

Following recommendation, removing unnecessary parentheses.

[alfredo]

LGTM