Page MenuHomeFreeBSD

Add support for failover LAGG mode to IBCORE
AbandonedPublic

Authored by hselasky on Mar 2 2020, 3:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 1:56 PM
Unknown Object (File)
Mar 25 2024, 10:29 PM
Unknown Object (File)
Jan 26 2024, 11:14 PM
Unknown Object (File)
Dec 26 2023, 5:44 AM
Unknown Object (File)
Dec 20 2023, 7:18 AM
Unknown Object (File)
Nov 8 2023, 2:34 AM
Unknown Object (File)
Nov 7 2023, 7:39 PM
Unknown Object (File)
Oct 7 2023, 1:30 AM
Subscribers

Details

Reviewers
kib
gallatin
Summary

Work in progress patch.

Sponsored by: Mellanox Technologies

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 29739

Event Timeline

sys/net/if.c
2279

Why not strcmp(ifp->if_dname, "lagg") ?

2288

That's a certainly a generic function that is needed.

Can we leave the vlan/lagg implementation logic inside appropriate modules and avoid polluting if.c?
For example, can we hide the appropriate chunks into function like vlan_get_parent(ifp) and lagg_is_parent_of(ifp) with these functions residing in if_vlan.c and if_lagg.c?

2340

Typo: inerface

2345

Same here:
Can this be something like vlan_get_parent(ifp) and lagg_get_active_trunk(ifp) residing in if_vlan.c? if_lagg.c?

sys/net/if_var.h
474

Maybe it would help the other potential consumers of this eventhandler if events could be further split into LAGG_PORT_<UP|DOWN|CHANGE>

hselasky marked 2 inline comments as done.

Address some feedback from @melifaro .

@melifaro : I'm currently waiting for feedback form @kib .

sys/net/if.c
2288

Because the function is recursive, I think an all-in-one approach is more readable.