Page MenuHomeFreeBSD

linuxkpi: extend range of nsecs_to_jiffies64 to support Mesa's drm_syncobj usage
ClosedPublic

Authored by hselasky on Feb 26 2020, 9:10 PM.

Details

Summary

For Some Reason™ we've been experiencing breakage in Vulkan fences (implemented using DRM syncobj).

@jbeich noticed that changing INT64_MAX to INT32_MAX in the part of Mesa that sets the timeout_nsec field on the drm_syncobj_wait struct fixes it. Well, turns out Mesa has been relying on the implementation details of Linux's nsecs_to_jiffies64 — it supports a wider range of numbers, and INT64_MAX works fine. Let's do a similar thing I guess..

Test Plan

Rebuild drm-kms after adding this patch, reboot, retry using Vulkan applications (e.g. vkquake) — now they work fine instead of quitting almost instantly.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hselasky updated this revision to Diff 68861.
hselasky edited reviewers, added: greg_unrelenting.technology; removed: hselasky.

Hi Greg,

Can you test this patch instead?

--HPS

Wow, that's a lot more code :D But yeah, works fine.

This revision is now accepted and ready to land.Feb 26 2020, 10:54 PM

I just have to give it a spin at work tomorrow and I'll submit it.