Paths

Table of Contentst

Differential D23846

linuxkpi: extend range of nsecs_to_jiffies64 to support Mesa's drm_syncobj usage
ClosedPublic
Actions

Authored by • hselasky on Feb 26 2020, 9:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 16, 5:00 AM

	Unknown Object (File)
	Sat, Aug 15, 10:26 PM

	Unknown Object (File)
	Sat, Aug 15, 2:12 AM

	Unknown Object (File)
	Thu, Aug 13, 10:31 AM

	Unknown Object (File)
	Tue, Aug 11, 12:29 PM

	Unknown Object (File)
	Tue, Aug 11, 11:32 AM

	Unknown Object (File)
	Mon, Aug 10, 11:15 PM

	Unknown Object (File)
	Sun, Aug 9, 3:02 PM

Subscribers

Details

Reviewers

val_packett.cool

Group Reviewers

Contributor Reviews (src)

Commits

rS358700: MFC r358387:
rS358699: MFC r358387:
rS358387: Extend the range of the return value from nsecs_to_jiffies64() to support

Summary

For Some Reason™ we've been experiencing breakage in Vulkan fences (implemented using DRM syncobj).

@jbeich noticed that changing INT64_MAX to INT32_MAX in the part of Mesa that sets the timeout_nsec field on the drm_syncobj_wait struct fixes it. Well, turns out Mesa has been relying on the implementation details of Linux's nsecs_to_jiffies64 — it supports a wider range of numbers, and INT64_MAX works fine. Let's do a similar thing I guess..

Test Plan

Rebuild drm-kms after adding this patch, reboot, retry using Vulkan applications (e.g. vkquake) — now they work fine instead of quitting almost instantly.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Feb 26 2020, 9:10 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptFeb 26 2020, 9:10 PM

Hi Greg,

Can you test this patch instead?

--HPS

Harbormaster completed remote builds in B29631: Diff 68861.Feb 26 2020, 9:52 PM

Wow, that's a lot more code :D But yeah, works fine.

This revision is now accepted and ready to land.Feb 26 2020, 10:54 PM

I just have to give it a spin at work tomorrow and I'll submit it.

Closed by commit rS358387: Extend the range of the return value from nsecs_to_jiffies64() to support (authored by • hselasky). · Explain WhyFeb 27 2020, 3:21 PM

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rS358387: Extend the range of the return value from nsecs_to_jiffies64() to support.

• hselasky added a commit: rS358699: MFC r358387:.Mar 6 2020, 1:57 PM

• hselasky added a commit: rS358700: MFC r358387:.

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linuxkpi/

common/

include/

linux/

55 lines

src/

50 lines

Diff 68883

head/sys/compat/linuxkpi/common/include/linux/jiffies.h

Loading...

head/sys/compat/linuxkpi/common/src/linux_compat.c

Loading...