Details
- Reviewers
val_packett.cool zeising grembo - Group Reviewers
x11 - Commits
- rP527043: devel/libepoll-shim: update to 0.0.20200223
Builds fine on:
- 11.3 aarch64
- 11.3 amd64
- 11.3 armv6
- 11.3 i386
- 12.0 amd64
- 12.0 i386
- 12.1 aarch64
- 12.1 amd64
- 12.1 armv6
- 12.1 armv7
- 12.1 i386
- 13.0 amd64
- 13.0 i386
- lang/gcc9 (mimics powerpc*)
- make test
Works fine on:
- www/firefox + MOZ_ENABLE_WAYLAND
- x11-drivers/xf86-input-libinput
- x11-wm/sway
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
I believe a portrevision bump of wayland is warranted, since it changes the code wayland is compiled with.
| graphics/wayland/Makefile | ||
|---|---|---|
| 24–25 ↗ | (On Diff #68691) | The intent was to enforce specific version of the dependency i.e., prevent users from using old libepoll-shim with new libwayland. However, this was never done in this past, so it doesn't make sense to start now. |
LGTM, I'll leave it to you to decide on committing it now, or holding for D23696.
| graphics/wayland/Makefile | ||
|---|---|---|
| 24–25 ↗ | (On Diff #68691) | It's OK to do that, however, the libepoll-shim line was duplicated, once with the version check and once without. I believe you can do the version check with LIB_DEPENDS as well. |
I can't comment on the wayland bits and I also don't have the time to test the changes in epoll-shim any time soon.
So I'm basically accepting the changes to the libepoll-shim port skeleton.. :)
