Page MenuHomeFreeBSD

devel/libepoll-shim: update to 0.0.20200223
ClosedPublic

Authored by jbeich on Feb 22 2020, 11:34 PM.

Details

Summary
Test Plan

Builds fine on:

  • 11.3 aarch64
  • 11.3 amd64
  • 11.3 armv6
  • 11.3 i386
  • 12.0 amd64
  • 12.0 i386
  • 12.1 aarch64
  • 12.1 amd64
  • 12.1 armv6
  • 12.1 armv7
  • 12.1 i386
  • 13.0 amd64
  • 13.0 i386
  • lang/gcc9 (mimics powerpc*)
  • make test

Works fine on:

  • www/firefox + MOZ_ENABLE_WAYLAND
  • x11-drivers/xf86-input-libinput
  • x11-wm/sway

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbeich created this revision.Feb 22 2020, 11:34 PM

I believe a portrevision bump of wayland is warranted, since it changes the code wayland is compiled with.

zeising added inline comments.Feb 23 2020, 6:54 PM
devel/libepoll-shim/Makefile
17–19 ↗(On Diff #68691)

Can you switch back to the FreeBSDDesktop repo, commit ae12186?

graphics/wayland/Makefile
24–25 ↗(On Diff #68691)

Duplicate

jbeich updated this revision to Diff 68717.Feb 23 2020, 7:14 PM
jbeich edited the summary of this revision. (Show Details)
jbeich marked 2 inline comments as done.Feb 23 2020, 7:17 PM
jbeich added inline comments.
graphics/wayland/Makefile
24–25 ↗(On Diff #68691)

The intent was to enforce specific version of the dependency i.e., prevent users from using old libepoll-shim with new libwayland. However, this was never done in this past, so it doesn't make sense to start now.

jbeich marked an inline comment as done.Feb 23 2020, 7:17 PM
zeising accepted this revision.Feb 23 2020, 7:21 PM

LGTM, I'll leave it to you to decide on committing it now, or holding for D23696.

graphics/wayland/Makefile
24–25 ↗(On Diff #68691)

It's OK to do that, however, the libepoll-shim line was duplicated, once with the version check and once without. I believe you can do the version check with LIB_DEPENDS as well.

This revision is now accepted and ready to land.Feb 23 2020, 7:21 PM
jbeich retitled this revision from devel/libepoll-shim: update to 0.0.20200222 to devel/libepoll-shim: update to 0.0.20200223.Feb 23 2020, 7:23 PM
jbeich edited the summary of this revision. (Show Details)
jbeich edited the test plan for this revision. (Show Details)

Michael, does this work fine for you as well?

jbeich updated this revision to Diff 68719.Feb 23 2020, 8:09 PM
  • Rebase PORTREVISION as this will land before D23696 (minor optimization)
This revision now requires review to proceed.Feb 23 2020, 8:09 PM
grembo accepted this revision.Feb 23 2020, 10:51 PM

Michael, does this work fine for you as well?

I can't comment on the wayland bits and I also don't have the time to test the changes in epoll-shim any time soon.

So I'm basically accepting the changes to the libepoll-shim port skeleton.. :)

Macro ssshipit:

This revision is now accepted and ready to land.Feb 23 2020, 10:51 PM
This revision was automatically updated to reflect the committed changes.