Page MenuHomeFreeBSD

graphics/wayland: replace posix_fallocate hack with a proper fix
ClosedPublic

Authored by jbeich on Feb 15 2020, 3:48 PM.

Details

Test Plan

Builds fine on:

  • 11.3 aarch64
  • 11.3 amd64
  • 11.3 armv6
  • 11.3 i386
  • 12.0 amd64
  • 12.0 i386
  • 12.1 aarch64
  • 12.1 amd64
  • 12.1 armv6
  • 12.1 armv7
  • 12.1 i386
  • 13.0 amd64
  • 13.0 i386
  • Base GCC 4.2.1 (mimics powerpc*, mips*, riscv64)

Works fine on:

  • www/firefox + MOZ_ENABLE_WAYLAND
  • x11-servers/xwayland-devel
  • x11-wm/sway

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

There are comments on the suggested patches upstream. Until those are resolved, this is not approved.

https://gitlab.freedesktop.org/wayland/wayland/merge_requests/61
Here is a link to the upstream pull request and discussion, it's also linked in the Makefile, but put it here as well.

Looks promising, let's wait a bit for upstream to at least ack the patches.

Stalled until someone can reproduce the original issue. I dogfood XDG_RUNTIME_DIR=/var/run/$USER on tmpfs(5). Sway works fine even after changing XDG_RUNTIME_DIR to point to a directory on ZFS

Stalled until someone can reproduce the original issue. I dogfood XDG_RUNTIME_DIR=/var/run/$USER on tmpfs(5). Sway works fine even after changing XDG_RUNTIME_DIR to point to a directory on ZFS

With your patches you mean ? Because I recall that I needed to change it to a non-zfs filesystem not so long ago.

In D23696#520294, @manu wrote:

Stalled until someone can reproduce the original issue. I dogfood XDG_RUNTIME_DIR=/var/run/$USER on tmpfs(5). Sway works fine even after changing XDG_RUNTIME_DIR to point to a directory on ZFS

With your patches you mean ?

Without the hack and my patches from here. However, I can't rely on my QA alone as I have a number of patches against kernel/userland/ports/etc.

In D23696#520294, @manu wrote:

Stalled until someone can reproduce the original issue. I dogfood XDG_RUNTIME_DIR=/var/run/$USER on tmpfs(5). Sway works fine even after changing XDG_RUNTIME_DIR to point to a directory on ZFS

With your patches you mean ?

Without the hack and my patches from here. However, I can't rely on my QA alone as I have a number of patches against kernel/userland/ports/etc.

Ok, I'll try on my machine.

In D23696#520296, @manu wrote:
In D23696#520294, @manu wrote:

Stalled until someone can reproduce the original issue. I dogfood XDG_RUNTIME_DIR=/var/run/$USER on tmpfs(5). Sway works fine even after changing XDG_RUNTIME_DIR to point to a directory on ZFS

With your patches you mean ?

Without the hack and my patches from here. However, I can't rely on my QA alone as I have a number of patches against kernel/userland/ports/etc.

Ok, I'll try on my machine.

Works for me for XDG_RUNTIME_DIR on both tmpfs and zfs

jbeich edited the test plan for this revision. (Show Details)
  • Address upstream review

Anonymous memory is not backed by any filesystem, so posix_fallocate generally succeeds. I had to temporarily delete defined(HAVE_MEMFD_CREATE) and defined(__FreeBSD__) conditionals during testing.

Upstream has merged my PR:

  • Switch to patches with Signed-off-by
This revision is now accepted and ready to land.Feb 24 2020, 3:40 PM