netgraph/ng_one2many: Clarification in comments about copy mode
ClosedPublic
Actions

Authored by donner on Feb 17 2020, 2:58 PM.

Details

Reviewers

nc
kp

Group Reviewers

network

Commits

R10:c3e75b6c1a02: netgraph/ng_one2main: Clarification in comments about copy mode

Summary

In D23721 an old comment pointing to a probably more performant way was proven wrong.
Remove the comment, so that others do not run into this issue again.

Diff Detail

Repository

R10 FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

donner created this revision.Feb 17 2020, 2:58 PM

Herald added subscribers: Contributor Reviews (base), melifaro, imp. · View Herald TranscriptFeb 17 2020, 2:58 PM

Harbormaster completed remote builds in B29446: Diff 68455.Feb 17 2020, 2:58 PM

donner added a reviewer: nc.Feb 17 2020, 2:59 PM

Looks good to me.

This revision is now accepted and ready to land.Feb 17 2020, 5:39 PM

I thought about one "alternative": a copy-on-write mode for mbufs. However, this means modifications to the mbuf code.

In D23727#525485, @neel_neelc.org wrote:

I thought about one "alternative": a copy-on-write mode for mbufs. However, this means modifications to the mbuf code.

That would be a new review.

donner added a reviewer: network.Mar 7 2020, 9:45 PM

Rebase to r366170.

This revision now requires review to proceed.Sep 25 2020, 7:26 PM

Harbormaster completed remote builds in B33825: Diff 77544.Sep 25 2020, 7:26 PM