netgraph/ng_one2many: Clarification in comments about copy mode
Needs ReviewPublic
Actions

Authored by lutz_donnerhacke.de on Feb 17 2020, 2:58 PM.

Details

Reviewers

Group Reviewers

Summary

In D23721 an old comment pointing to a probably more performant way was proven wrong.
Remove the comment, so that others do not run into this issue again.

Diff Detail

Repository

rS FreeBSD src repository

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 33825
Build 31042: arc lint + arc unit

Event Timeline

lutz_donnerhacke.de created this revision.Feb 17 2020, 2:58 PM

Herald added subscribers: Contributor Reviews (base), melifaro, imp. · View Herald TranscriptFeb 17 2020, 2:58 PM

Harbormaster completed remote builds in B29446: Diff 68455.Feb 17 2020, 2:58 PM

lutz_donnerhacke.de added a reviewer: neel_neelc.org.Feb 17 2020, 2:59 PM

Looks good to me.

This revision is now accepted and ready to land.Feb 17 2020, 5:39 PM

I thought about one "alternative": a copy-on-write mode for mbufs. However, this means modifications to the mbuf code.

In D23727#525485, @neel_neelc.org wrote:

I thought about one "alternative": a copy-on-write mode for mbufs. However, this means modifications to the mbuf code.

That would be a new review.

lutz_donnerhacke.de added a reviewer: network.Mar 7 2020, 9:45 PM

Rebase to r366170.

This revision now requires review to proceed.Fri, Sep 25, 7:26 PM

Harbormaster completed remote builds in B33825: Diff 77544.Fri, Sep 25, 7:26 PM