Page MenuHomeFreeBSD

netgraph/ng_one2many: Clarification in comments about copy mode
Needs ReviewPublic

Authored by lutz_donnerhacke.de on Feb 17 2020, 2:58 PM.

Details

Reviewers
neel_neelc.org
Group Reviewers
network
Summary

In D23721 an old comment pointing to a probably more performant way was proven wrong.
Remove the comment, so that others do not run into this issue again.

Diff Detail

Repository
rS FreeBSD src repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33825
Build 31042: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 17 2020, 5:39 PM

I thought about one "alternative": a copy-on-write mode for mbufs. However, this means modifications to the mbuf code.

I thought about one "alternative": a copy-on-write mode for mbufs. However, this means modifications to the mbuf code.

That would be a new review.

This revision now requires review to proceed.Fri, Sep 25, 7:26 PM